Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got Dataverse working on Windows in Vagrant and Minishift #3927 #4531

Merged
merged 3 commits into from
Apr 9, 2018

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Mar 21, 2018

connects to #3927 How to get Dataverse running on a Windows computer for development

@coveralls
Copy link

coveralls commented Mar 21, 2018

Coverage Status

Coverage decreased (-0.005%) to 12.911% when pulling 3eb44c6 on 3927-windows-dev into cdb4e48 on develop.

pdurbin added 2 commits March 26, 2018 12:48
Also, clean up references to Windows in other parts of the dev guide.
@pdurbin pdurbin changed the title got Dataverse working on Windows in Vagrant #3927 got Dataverse working on Windows in Vagrant and Minishift #3927 Mar 26, 2018
@pdurbin
Copy link
Member Author

pdurbin commented Mar 26, 2018

Typo? "...but he haven't tried it."

Whoops. Fixed in 3eb44c6. Good catch, @mheppler . Thanks!

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'm curious to see how well this process works with Windows versions other than 10. (I don't see why it wouldn't; well, as long as Vagrant can be installed, I feel like it should run on any version...) Maybe we'll try some older Windows as part of QA.

@kcondon kcondon merged commit 2c4b816 into develop Apr 9, 2018
@kcondon kcondon deleted the 3927-windows-dev branch April 9, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants