Add Postgresql statefulsets with master/slave replication on OpenShift. #4599

patrickdillon · 2018-04-18T14:43:33Z

This pull requests modifies openshift.json to set up a postgres statefulset with master/slave replication.

This pull request requires that the dataverse glassfish image be rebuilt with the small tweak I committed in default.config (pointing to the master postgres pod). To test, perhaps before rebuilding the image, you can point to my docker image by changing line 113 in openshift.json to "dockerImageRepository": "patrickdillon/dataverse-glassfish"

No changes have been made to run dv on openshift:
oc new-project [name]
oc new-app openshift.json

Once you have started, you can test with the psql client in each container. From the terminal in each postgres container, you can login and check that the tables were created. That should be enough to show changes from master have been replicated:
psql -d dvndb
\dt

You can also make a change, such as changing the name of the dataverse from root to something else and then checking that with select * from dataverse;

I still need to update my Dockerhub image to incorporate the fixes to solr. I will do that soon and update if there are problems.

Related Issues

connects to Add Postgresql Statefulsets with Replication to OpenShift/Kubernetes #4598

coveralls · 2018-04-18T14:48:04Z

Coverage increased (+0.2%) to 13.293% when pulling e7a56c7 on EC528-Dataverse-Scaling:4598-openshift-postgresql into 747b83c on IQSS:develop.

pameyer · 2018-04-18T16:07:26Z

doc/sphinx-guides/source/_static/util/default.config

@@ -3,7 +3,7 @@ GLASSFISH_DIRECTORY	/usr/local/glassfish4
 ADMIN_EMAIL	 
 MAIL_SERVER	mail.hmdc.harvard.edu
 POSTGRES_ADMIN_PASSWORD	secret
-POSTGRES_SERVER	127.0.0.1
+POSTGRES_SERVER	dataverse-postgresql-0.dataverse-postgresql-service


This changes the default behavior (and default documentation example) to openshift - this change might be better to make in conf/docker/dataverse-glassfish/default.config.

Right, we don't want to affect the "here" link at "If desired, these default values can be configured by creating a default.config (example here) file in the installer’s working directory" at http://guides.dataverse.org/en/4.8.6/installation/installation-main.html#running-the-dataverse-installer

Good catch @pameyer

@patrickdillon can you please put the "doc" version of the file back to how it was and make the change in conf/docker/dataverse-glassfish/default.config instead? Thanks!

I understand. I believe I have fixed this now.

@patrickdillon Thanks! Looks fixed to me.

danmcp · 2018-04-18T16:32:46Z

conf/openshift/openshift.json

@@ -42,6 +42,7 @@
        "selector": {
          "name": "iqss-dataverse-postgresql"
        },
+	"clusterIP": "None",


Formatting looks off.

Add Postgresql statefulsets with master/slave replication on OpoenShift. Simple test. Non functional. Adding missing semicolon. Glassfish starts but no dataverse. Glassfish can connect to postgres but does not save in application. Fixing service problem with postgres stateful set. going to try to break command over multiple lines. WIP extending image with S2I Replication is working. Just needs to be cleaned up. Cleaned up. Removing print tests. Resetting install to upstream. Resetting build.sh to upstream. Fixing image pull policy. Fixing default config. Fixing formatting issues. More formatting.

patrickdillon · 2018-04-23T13:37:00Z

conf/openshift/openshift.json

      "metadata": {
        "name": "dataverse-postgresql",
        "annotations": {
          "template.alpha.openshift.io/wait-for-ready": "true"
        }
      },
      "spec": {
+        "serviceName" : "dataverse-postgresql-service",
+        "replicas" : 1,


@danmcp raised the question of whether running a setup with only a master and no slaves would have any side effects. I think there would be no side effects and it would be similar to just running a single instance Postgres setup.

Our code is based off this example, which states:

Once the master is started, it works as a standalone database server, fully independent of the slaves.

I dug in a little more to the image to see what is happening:
For the postgres image, the only side effect for running as master is that these configuration settings are copied into the main postgres config file: https://github.com/sclorg/postgresql-container/blob/master/src/root/usr/share/container-scripts/postgresql/openshift-custom-postgresql-replication.conf.template

To me, the above settings look innocuous.

For further context, here is the master-binary: https://github.com/sclorg/postgresql-container/blob/master/src/root/usr/bin/run-postgresql-master

And that environment variable is called in this common script, which just copies the first file above into the main config settings: https://github.com/sclorg/postgresql-container/blob/b737ad26db4f8769e775ca165284f62c7f2a66db/src/root/usr/share/container-scripts/postgresql/common.sh

@patrickdillon thanks, I just moved this to QA.

pdurbin

Looks good.

patrickdillon · 2018-04-23T14:58:14Z

conf/openshift/openshift.json

@@ -241,7 +248,10 @@
            "containers": [
              {
                "name": "centos-postgresql-94-centos7",
-                "image": "centos-postgresql-94-centos7",
+                "image": "centos/postgresql-94-centos7",


By using centos/postgresql-94-centos7 instead of centos-postgresql-94-centos7 we are pointing directly to the Docker Hub repo rather than the ImageStream. The reason I changed this was because it started throwing an error after changing from a DeploymentConfig to a StatefulSet v1beta1. I just tried testing again with the image stream and it still is getting the error. Once OpenShift is updated to a newer version we can try changing it back or if there are any suggestions let me know.

pdurbin · 2018-04-23T19:27:53Z

conf/openshift/openshift.json

-      "kind": "DeploymentConfig",
-      "apiVersion": "v1",
+      "kind": "StatefulSet",
+      "apiVersion": "apps/v1beta1",


Does v1beta1 require a beta version of minishift? Or can I just use the most recent regular release of minishift?

Regular release is fine. I was running on v1.14

Ok, great. Thanks.

pameyer reviewed Apr 18, 2018

View reviewed changes

danmcp reviewed Apr 18, 2018

View reviewed changes

patrickdillon mentioned this pull request Apr 18, 2018

Add Postgresql Statefulsets with Replication to OpenShift/Kubernetes #4598

Closed

patrickdillon force-pushed the 4598-openshift-postgresql branch from 1228f2d to e3924e4 Compare April 18, 2018 18:55

pdurbin assigned pdurbin and unassigned pdurbin Apr 18, 2018

patrickdillon force-pushed the 4598-openshift-postgresql branch from e3924e4 to 0b76e1d Compare April 23, 2018 13:23

patrickdillon force-pushed the 4598-openshift-postgresql branch from 0b76e1d to 51cecfc Compare April 23, 2018 13:26

patrickdillon commented Apr 23, 2018

View reviewed changes

pdurbin approved these changes Apr 23, 2018

View reviewed changes

patrickdillon commented Apr 23, 2018

View reviewed changes

pdurbin reviewed Apr 23, 2018

View reviewed changes

add huborg <USERNAME/ORG> for non-iqss Docker Hub IQSS#4599

e7a56c7

pdurbin mentioned this pull request Apr 25, 2018

Add Glassfish Statefulsets to OpenShift/Kubernetes #4617

Closed

pdurbin merged commit 0e38c90 into IQSS:develop Apr 25, 2018

pdurbin added this to the 4.9 - Persistent Identifiers for Files milestone Apr 26, 2018

pdurbin mentioned this pull request Apr 27, 2018

Adding Glassfish Statefulsets for OpenShift Deployment #4626

Merged

pdurbin mentioned this pull request May 25, 2018

Docker for production #4665

Closed

This was referenced Jun 20, 2018

Solr Container Scaling #4762

Closed

Allow Dataverse to work with secondary reads from a scaled database #4765

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Postgresql statefulsets with master/slave replication on OpenShift. #4599

Add Postgresql statefulsets with master/slave replication on OpenShift. #4599

patrickdillon commented Apr 18, 2018 •

edited by pdurbin

Loading

coveralls commented Apr 18, 2018 •

edited

Loading

pameyer Apr 18, 2018

pdurbin Apr 18, 2018

patrickdillon Apr 18, 2018

pameyer Apr 18, 2018

danmcp Apr 18, 2018

patrickdillon Apr 23, 2018

pdurbin Apr 23, 2018

pdurbin left a comment

patrickdillon Apr 23, 2018

pdurbin Apr 23, 2018

patrickdillon Apr 23, 2018

pdurbin Apr 23, 2018

Add Postgresql statefulsets with master/slave replication on OpenShift. #4599

Add Postgresql statefulsets with master/slave replication on OpenShift. #4599

Conversation

patrickdillon commented Apr 18, 2018 • edited by pdurbin Loading

Related Issues

coveralls commented Apr 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pdurbin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patrickdillon commented Apr 18, 2018 •

edited by pdurbin

Loading

coveralls commented Apr 18, 2018 •

edited

Loading