Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4763: Users and passwords randomly generated and stored in env #4827

Merged
merged 2 commits into from
Jul 20, 2018
Merged

4763: Users and passwords randomly generated and stored in env #4827

merged 2 commits into from
Jul 20, 2018

Conversation

tkmonson
Copy link
Contributor

@tkmonson tkmonson commented Jul 10, 2018 •
edited by pdurbin
Loading

connects to #4763

pdurbin
pdurbin approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same commit from 12 days ago that I approved as part of #4809. This time we'll put it through QA. Approved!

@tkmonson tkmonson mentioned this pull request Jul 10, 2018
Merged
@pdurbin pdurbin mentioned this pull request Jul 10, 2018
Closed
@coveralls
Copy link

coveralls commented Jul 10, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 15.547% when pulling afa1b17 on tkmonson:4763_separate_secrets_B into 188bf38 on IQSS:develop.

@pdurbin pdurbin mentioned this pull request Jul 19, 2018
Closed
@kcondon kcondon merged commit 2efdf2f into IQSS:develop Jul 20, 2018
@pdurbin pdurbin added this to the 4.9.2 - Stata Upgrades, etc. milestone Jul 20, 2018
tkmonson pushed a commit to tkmonson/dataverse that referenced this pull request Aug 3, 2018
@kcondon @tkmonson
Merge pull request IQSS#4827 from tkmonson/4763_separate_secrets_B
aa058d9 
4763: Users and passwords randomly generated and stored in env
@pdurbin pdurbin mentioned this pull request Aug 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdurbin pdurbin pdurbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9.2 - Stata Upgrades, etc.
Development

Successfully merging this pull request may close these issues.
4 participants
@tkmonson @coveralls @pdurbin @kcondon