5457-provide dataset/version/filemetadata to External tools #5465
Conversation
| @@ -235,6 +235,10 @@ public void explore(GuestbookResponse guestbookResponse, FileMetadata fmd, Exter | |||
| dataFile = guestbookResponse.getDataFile(); | |||
| } | |||
| } | |||
| //For tools to get the dataset and datasetversion ids, we need a full DataFile object (not a findCheapAndEasy() copy) | |||
There was a problem hiding this comment.
@qqmyers this looks fine but have you seen any performance issue here? If so, we could right some helper method like doesExternalToolNeedDataset(externalTool). But if there's trivial performance impact, not worth it.
There was a problem hiding this comment.
@scolapasta - I think it's trivial - this is only called during tool launch and it is then a lookup of one datafile object. I didn't see any obvious delay launching a tool and I think the main concerns previously have been for cases where many datafiles were being looked up, e.g. when scanning through the list in a dataset...
There was a problem hiding this comment.
OK, great. That is what I assumed as well, and why I had already moved to QA. :)
| API_TOKEN("apiToken"); | ||
| API_TOKEN("apiToken"), | ||
| DATASET_ID("datasetId"), | ||
| DATASET_VERSION("datasetVersion"); |
There was a problem hiding this comment.
@qqmyers can you please add these two new reserved words (datasetId and datasetVersion) to the list of possibilities? The current list can be found at http://guides.dataverse.org/en/4.10.1/installation/external-tools.html
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist