Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5725 initial CI documentation #5751

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Conversation

donsizemore
Copy link
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.99% when pulling 42c6f81 on OdumInstitute:5725_CI_documentation into 879bb73 on IQSS:develop.


Our Jenkins config is a work in progress and may be viewed at https://github.com/IQSS/dataverse-jenkins/ A corresponding GitHub webhook is required. Build output is viewable at https://jenkins.dataverse.org/

As always, pull requests to improve our continuous integration configurations are welcome.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donsizemore I'm glad you're characterizing the dataverse-jenkins (the git repo) and https://jenkins.dataverse.org as a work in progress. I think you've stubbed this out very well. Thanks!!

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks fine to me. FWIW QDR isn't using this at present (except for the connection through PRs) - we have a different Chef/Jenkins/Github integration going. Might be something we can leverage going forward though...

@pdurbin
Copy link
Member

pdurbin commented Apr 11, 2019

except for the connection through PRs

@qqmyers thanks, can you please expand on this a bit? Right now we have Travis integrated such that we see when checks done by Travis pass or fail, like this example from pull request #5621:

Screen Shot 2019-04-11 at 10 46 17 AM

Are you saying that from GitHub you see "All checks have passed" (or failures) based on testing done on Jenkins?

@qqmyers
Copy link
Member

qqmyers commented Apr 11, 2019

@pdurbin - I just meant that I use Dataverse's build system when I submit PRs. Otherwise, when I'm developing, I'm relying on QDR's build system and checking test results in our jenkins console, etc. W.r.t. integration, I'm not sure how its done in QDR, but new builds are triggered by my commits to github - I don't think the results get back to github (not sure I've looked).

@4tikhonov
Copy link
Contributor

Hi @pdurbin and others, we're not going to create a clone of Dataverse, the idea that all our contribution should go to the master branch. And we already have first priorities for development in DataverseEU.

@pdurbin
Copy link
Member

pdurbin commented Apr 11, 2019

@4tikhonov yes, of course, and we're looking forward to pull requests from you and the rest of the DataverseEU developers! What I was trying to say at #5725 (comment) is that I'm wondering if I can get an account on your CI pipeline system. I showed your slides to @djbrooke this morning and said, "It's like Slava's throwing a continuous integration party and I hope I get invited!" 🎉 🎈 Is it possible for me to trigger a build on your system and see if I broke anything when I push code? Do I need an account? Can I get an account? 😄 I'd love to play in your playground, if you're ok with that. 😄

@4tikhonov
Copy link
Contributor

@pdurbin, sure, I think it's not a problem. We're discussing now to setup two different DataverseEU instances, first on CESSDA Google Cloud (for sure) and second on Kubernetes cluster in Poland (it has to be finally decided). Guys from Poland also interested to deliver polish translation, so just stay tuned. :)

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Don!

@kcondon kcondon merged commit fc070ce into IQSS:develop Apr 16, 2019
@pdurbin pdurbin added this to the 4.13 milestone Apr 22, 2019
@pdurbin pdurbin mentioned this pull request Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants