set INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL to false #5907 #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We definitely INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL to true purposefully, though I don't recall the exact thing that needed it.(possibly the way we handle "required" validation?) Regardless a different solution was found, so am closing this PR. |
The different solution was pull request #5933 but it caused new problems (unable to create a dataverse) so we reverted it with pull request #5944. Should we revisit this fix, perhaps after absorbing this very long blog post? http://balusc.omnifaces.org/2015/10/the-empty-string-madness.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5907