Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed italic tags to span tags for custom icons [ref #6144] #6145

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Changed italic tags to span tags for custom icons [ref #6144] #6145

merged 1 commit into from
Sep 9, 2019

Conversation

mheppler
Copy link
Contributor

@mheppler mheppler commented Sep 5, 2019

Related Issues

Pull Request Checklist

@dataversebot
Copy link

Can one of the admins verify this patch?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.488% when pulling 8b8aa55 on 6144-icon-tag-cleanup into 09fe94b on develop.

pdurbin
pdurbin approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing crazy in here.

@kcondon kcondon merged commit 4460895 into develop Sep 9, 2019
@kcondon kcondon deleted the 6144-icon-tag-cleanup branch September 9, 2019 17:54
@kcondon kcondon self-assigned this Sep 9, 2019
@djbrooke djbrooke added this to the 4.17 milestone Sep 18, 2019
@pdurbin pdurbin mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdurbin pdurbin pdurbin approved these changes

Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.17
Development

Successfully merging this pull request may close these issues.

Code Cleanup - i tag used for icons bad practice
6 participants
@mheppler @dataversebot @coveralls @pdurbin @kcondon @djbrooke