Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get deployment working again for new installations #6165 #6166

Merged
merged 1 commit into from
Sep 13, 2019
Merged

get deployment working again for new installations #6165 #6166

merged 1 commit into from
Sep 13, 2019

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Sep 12, 2019

Fixes #6165 Can't deploy: ERROR: column "id" of relation "setting" already exists

@pdurbin pdurbin mentioned this pull request Sep 12, 2019
Closed
@dataversebot
Copy link

Can one of the admins verify this patch?

@poikilotherm
Copy link
Contributor

poikilotherm commented Sep 13, 2019 •
edited
Loading

😭 😭 😭 😭 😭 😭 😭
I cannot deploy to my clusters when developing for #5991 / #5997.
Can someone please take care of #5871 so this will not happen times and times again?
As always: willing to help.
(In case you didn't notice: I'm blocked 😞 )

poikilotherm
poikilotherm approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@poikilotherm poikilotherm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will obviously resolve the problem. But it is like cancer: you need to cut deep (see #5871) to get rid of spreading tumors.

Tested this by merging into #5997 and deployed to K8s successfully.

@JayanthyChengan
Copy link
Contributor

@pdurbin - yes, this will resolve the problem.

@kcondon kcondon self-assigned this Sep 13, 2019
@kcondon kcondon merged commit 22ee5e5 into develop Sep 13, 2019
@kcondon kcondon deleted the 6165-cannot-deploy branch September 13, 2019 17:29
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.472% when pulling 519662a on 6165-cannot-deploy into 9f41601 on develop.

@djbrooke djbrooke added this to the 4.17 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poikilotherm poikilotherm poikilotherm approved these changes

@sekmiller sekmiller sekmiller approved these changes

@JayanthyChengan JayanthyChengan Awaiting requested review from JayanthyChengan

Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.17
Development

Successfully merging this pull request may close these issues.

Can't deploy: ERROR: column "id" of relation "setting" already exists
8 participants
@pdurbin @dataversebot @poikilotherm @JayanthyChengan @coveralls @sekmiller @kcondon @djbrooke