Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix at 'Show the dataset whose id is passed' section #6083 #6183

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Fix at 'Show the dataset whose id is passed' section #6083 #6183

merged 2 commits into from
Jan 30, 2023

Conversation

pkiraly
Copy link
Member

@pkiraly pkiraly commented Sep 18, 2019

This pull request is one of a row of baby steps to fix URLs in API documentation.

Related Issues

@dataversebot
Copy link

Can one of the admins verify this patch?

pdurbin
pdurbin reviewed Sep 18, 2019
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better than what's there a close to what I had in mind. @pkiraly maybe I'll make a pull request into your branch so I can show you what I see as the next step.

@pdurbin pdurbin self-assigned this Sep 18, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.509% when pulling 8431d7f on pkiraly:6178-replace-GET-to-curl-02 into 6f8bdeb on IQSS:develop.

@pdurbin pdurbin removed their assignment Sep 19, 2019
@pdurbin
Copy link
Member

pdurbin commented Sep 19, 2019

@pkiraly let's work together on #6190 first. It should be much more straightforward than the "Get JSON Representation of a Dataset" one. I'm going to park this pull request in "community dev" for now. Thanks so much for helping us to improve the API Guide!!

@mreekie mreekie added the bk2211 label Nov 1, 2022
@pdurbin pdurbin added Type: Suggestion an idea Feature: API Guide User Role: API User Makes use of APIs Size: 3 A percentage of a sprint. 2.1 hours. labels Dec 15, 2022
@pdurbin
Merge branch 'develop' into 6178-replace-GET-to-curl-02 IQSS#6183
5c6d4d1 
Conflicts:
doc/sphinx-guides/source/api/native-api.rst

Also, update demo example to a working dataset.
@pdurbin
Copy link
Member

pdurbin commented Jan 3, 2023

@pkiraly it looks like you already made improvements in 65f6b3e as part of this PR:

However, rather than closing this PR I used it as an opportunity to make a further clarification and update the demo example to a dataset that works (id 24).

@mreekie
Copy link

mreekie commented Jan 10, 2023

Prio meeting with Stefano.

  • Moved from Community Backlog to ordered backlog

@mreekie mreekie removed the bk2211 label Jan 11, 2023
@kcondon kcondon self-assigned this Jan 30, 2023
@kcondon kcondon merged commit 48c645b into IQSS:develop Jan 30, 2023
@pdurbin pdurbin added this to the 5.13 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdurbin pdurbin pdurbin left review comments

@scolapasta scolapasta scolapasta approved these changes

Assignees

@kcondon kcondon

Labels
Feature: API Guide Size: 3 A percentage of a sprint. 2.1 hours. Type: Suggestion an idea User Role: API User Makes use of APIs
Projects
IQSS Dataverse Project
Status: No status
Milestone
5.13
Development

Successfully merging this pull request may close these issues.
7 participants
@pkiraly @dataversebot @coveralls @pdurbin @mreekie @scolapasta @kcondon