6216 - Repair broken dataverse view

[poikilotherm]

Related Issues

• Solves Root dataverse not shown when deploying on Payara 5 #6216.

TODOs / TODISCUSS

• Validation obviously did not work back on Glassfish 4.1. See Root dataverse not shown when deploying on Payara 5 #6216 for more "behind the scenes".
• Bean validation or JSF validation should ensure that no bad values are injected via alias, id, ownerid, etc. It might be usefull to create a custom validator + annotation using the Patterns, etc, as those allow null. The model var for alias could still have @NonBlank.
• I upgraded to OmniFaces 2.7.1, the last release version still supporting JSF 2.2. All of this stuff should be usable right away on GF 4.1, but more tests are needed.
• We need to discuss if you feel OK with my approach to handle the situation. There are others, but felt like the cleanest way: simply handle GET params not as part of the model.

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[coveralls]

Coverage decreased (-0.002%) to 19.504% when pulling 931b1e6 on poikilotherm:6216-broken-dataverse-view into c29c449 on IQSS:develop.

[pdurbin]

I just tried this:

./ec2-create-instance.sh -b 6216-broken-dataverse-view -r https://github.com/poikilotherm/dataverse.git -g ec2config.yaml

It failed with this:

TASK [dataverse : set logging format] ******************************************
fatal: [localhost]: FAILED! => {"changed": true, "cmd": "/usr/local/glassfish4/bin/asadmin set-log-file-format ulf", "delta": "0:00:00.427826", "end": "2019-09-25 20:45:34.561133", "msg": "non-zero return code", "rc": 1, "start": "2019-09-25 20:45:34.133307", "stderr": "Remote server does not listen for requests on [localhost:4848]. Is the server up?", "stderr_lines": ["Remote server does not listen for requests on [localhost:4848]. Is the server up?"], "stdout": "No such local command: set-log-file-format. Unable to access the server to execute the command remotely. Verify the server is available.\nCommand set-log-file-format failed.", "stdout_lines": ["No such local command: set-log-file-format. Unable to access the server to execute the command remotely. Verify the server is available.", "Command set-log-file-format failed."]}

If you look in /tmp/glassfish-setup.out you see this at the end:

Command create-javamail-resource executed successfully.
Updates done. Restarting...
Waiting for the domain to stop ......
Command stop-domain executed successfully.
Waiting for domain1 to start .......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
No response from the Domain Administration Server (domain1) after 600 seconds.
The command is either taking too long to complete or the server has failed.
Please see the server log files for command status.
Please start with the --verbose option in order to see early messages.
Command start-domain failed.
/tmp/dvinstall
Glassfish setup complete

Here's the complete output file: glassfish-setup.out.txt

Here's my config: ec2config.yaml.txt (note that I'm using payara-5.193.zip for the first time instead of payara-5.192.zip which I tested previously in IQSS/dataverse-ansible#70

I was on d42d00d in this pull request and IQSS/dataverse-ansible@f28686b

[scolapasta]

Hi @poikilotherm
Thanks for this PR. As I'm starting to take a more holistic view of this whole app server upgrade mission, we're going to hold off on merging this for now. It's likely we'll accept it later, as it seems a clean solution, but I'd like to to get my set up here first, try some things, etc.

[scolapasta]

Closing as these changes are now part of the branch for #6230 (except for the omnifaces upgrade).