-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6587 deleted files shown on grant permission #6659
6587 deleted files shown on grant permission #6659
Conversation
hard-coded to false for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few inline comments. Screenshots of the UI included in the issue or PR would help when reviewing. Didn't look at the java changes, if someone else wants to take a peek at those.
@mheppler as discussed I added the "include deleted files" check box to both panels. (Please see lines 53 and 165 - for additional formatting improvements.) Also, as discussed, I'll leave it to you to add the file path and re-style the name/path. Thanks! |
Talked to @sekmiller, talked to @sbarbosadataverse, going to try another approach. Rather than continuing with my effort to add more "Include Deleted Files" checkbox toggles to each of the tables in the panels and popups on the Restricted File Permissions pg, I am going to try to have only one checkbox toggle above the Restricted Files panel datatable, and remove the deleted files from ever displaying in the Grant File Access popup datatable. As Sonia pointed out, "there is no need to grant access to a deleted file", so there is no need to display deleted files in the Grant File Access popup and no need for a checkbox toggle. Here is what the Grant File Access popup looks like with the changes as of now, which include my attempt to add a checkbox toggle to the table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short of testing it myself, everything looks good.
@sekmiller I moved it into qa; one nitpicking thing though: there seems to be an extra semicolon typo-ed in line 153 of ManageFilePermissionsPage.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good.
What this PR does / why we need it:
This PR allows the admin to deal with file permissions without having to wade through files that have been deleted from previous dataset versions. through the use of a check box she may include deleted files in case there are residual permissions on the deleted files.
Which issue(s) this PR closes:
Closes #6587 Deleted files showing up as duplicates in Grant File Permissions
Special notes for your reviewer:
Added "Transient" fields to DataFile and Role Assignment Row for ease of use
Suggestions on how to test this:
Add permissions or request access on files, then delete them.
Does this PR introduce a user interface change?:
Minor UI change, reviewed with Sonia.
Is there a release notes update needed for this change?:
No
Additional documentation:
None