Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6593 payara docs #6816

Merged
merged 54 commits into from
Apr 29, 2020
Merged

6593 payara docs #6816

merged 54 commits into from
Apr 29, 2020

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Apr 13, 2020 •
edited
Loading

What this PR does / why we need it:

Many, many places in the guide reference Glassfish 4. For Dataverse 5 we are moving to Payara 5.

Which issue(s) this PR closes:

Closes #6593

Special notes for your reviewer:

  • Details about a patch to Mojarra (JSF) have not yet been included. Added in b361999
  • "app server" was used where it makes sense to
  • An attempt was made to use a Unix user called "dataverse" instead of "glassfish".
  • In the Installation Guide, should we delete the old Two Ravens content? I put a note saying "Please note that in the text below, Glassfish was changed to Payara but not tested."
  • When should we update Vagrant code? Started in a7c986d but deferred until Get Vagrant working on Payara and with updated installer #6849
  • When should we update docker-aio code? @pameyer said he'd work on this
  • When should we update docker-dcm code? @pameyer said he'd work on this
  • Should we clear out the "Containers" page in the dev guide and delete the related scripts, Openshift config and Docker files? The content is old and references Glassfish. Done in e72ba3c.

Suggestions on how to test this:

  • Try to install Dataverse on Payara 5 with these instructions.
  • Set up as many extra features (Make Data Count, etc.) as is reasonable.

Does this PR introduce a user interface change?:

No

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

@pdurbin
update downloading of Payara for devs #6593
bb1088d
@pdurbin
change gf to payara in intro #6593
6543722
@pdurbin
tell new devs to use the Python installer #6593
cce21f6 
The plan is for the Python installer to support Payara. See #6761.
@pdurbin
for dev tips, update Glassfish to Payara #6593
5f7a991
@pdurbin
update dev troubleshooting page gf to payara #6593
2341e4b
@pdurbin
update dev sql update page: gf to payara #6593
975a3af
@pdurbin
Merge branch 'develop' into 6593-payara-docs #6593
7cbd644
@pdurbin
change glassfish to payara on dev testing page #6593
5f521af
@pdurbin
dev coding style, debug, change gf to payara #6593
1892773
@pdurbin
remove glassfish from dev tools page #6593
4299107
@pdurbin
change glassfish to payara for MDC #6593
701ed43
@pdurbin
update big data, changing glassfish to payara #6593
cf0be7f
@pdurbin
update containers page, suggest rewrite #6593
bb21b5d
@pdurbin
in API Guide, change Glassfish to Payara #6593
85e8d8b
@pdurbin
change Glassfish to Payara in Admin Guide #6593
27e81ae
@pdurbin
update prep section: gf to payara #6593
45a41fb
@pdurbin
change gf to payara in prereq #6593
b8a2407
@pdurbin
change gf to payara in main install page #6593
4c326af
@pdurbin
switch docs from Perl installer to Python #6593
d7237e4
@pdurbin
change glassfish to payara on config page #6593
a8297bb
@pdurbin
move config page gf to payara changes #6593
0946d1f
@pdurbin
for TwoRavens page, change gf to payara #6593
bc5f64e
@pdurbin
shib docs, change gf to payara, rm grizzly patch #6593
8a1d1d1
@pdurbin
install guide: more gf to payara updates #6593
69f4720
@pdurbin
update ejb script for payara #6593
652252c
@pdurbin
update MDC config for Payara #6593
39ce1a2
@pdurbin
update Payara init script for root #6593
07bf75f
@pdurbin
update init script #6593
3655a13
@pdurbin
update systemd script for payara #6593
91e88b9
@pdurbin
use dataverse user, not glassfish #6593
ff21bb6
@pdurbin
Copy link
Member Author

pdurbin commented Apr 20, 2020

we should mention the jsf patch for those who will manually update their environment

I just added a line about the JSF patch in b361999.

@pdurbin
Copy link
Member Author

pdurbin commented Apr 20, 2020

I added a ton more "app server" references, as requested by @scolapasta

These are the open questions I have for reviewers:

  • In the Installation Guide, should we delete the old Two Ravens content? I put a note saying "Please note that in the text below, Glassfish was changed to Payara but not tested."
  • When should we update Vagrant code?
  • Should we clear out the "Containers" page in the dev guide and delete the related scripts, Openshift config and Docker files? The content is old and references Glassfish.

@pdurbin pdurbin removed their assignment Apr 20, 2020
@pdurbin pdurbin requested a review from scolapasta April 20, 2020 20:55
@pdurbin pdurbin marked this pull request as draft April 21, 2020 19:58
@pdurbin pdurbin self-assigned this Apr 21, 2020
@pdurbin
Copy link
Member Author

pdurbin commented Apr 21, 2020 •
edited
Loading

We discussed this pull request in tech hours and decided a few things.

  • I'd like to update (or possibly delete) the Vagrant stuff, which has references to Glassfish 4.1. Progress captured in a7c986d but deferred until Get Vagrant working on Payara and with updated installer #6849.
  • I'd like to delete the aging OpenShift content and files, which references Glassfish 4.1. Done in e72ba3c.
  • We'll let @pameyer update the docker-aio/docker-dcm content when he's ready (no rush!).
  • I'd like @landreev to take a look at the "run the installer" content in the Installation Guide. I made a few tweaks to it (making the new Python installer the default). @donsizemore mentioned that it should be written with an eye toward CentOS or RHEL rather than a laptop.

The other day in Slack we discussed Two Ravens.

  • @djbrooke will give us guidance if we can delete the "how to install TwoRavens" content, which had a lot of references to Glassfish.

If there are other things I'm forgetting, please let me know.

@pdurbin
start getting Vagrant working with Payara and new installer #6593
a7c986d 
We are deferring the rest of this work until #6849

Fixes #4519 (switched to dataverse-ansible Vagrantfile).

The guides have been updated to de-emphasize Vagrant.
@pdurbin pdurbin mentioned this pull request Apr 22, 2020
Closed
@pdurbin
remove OpenShift (references Glassfish 4.1) #6593
e72ba3c 
The OpenShift content has not been kept up to date. We can always dig it
out of the git history if necessary. A better starting point for
OpenShift support at this point is probably
https://github.com/IQSS/dataverse-kubernetes
@pdurbin pdurbin marked this pull request as ready for review April 22, 2020 15:58
@pdurbin pdurbin removed their assignment Apr 22, 2020
@scolapasta scolapasta self-assigned this Apr 23, 2020
scolapasta
scolapasta approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot, but I'm seeing the changes I requested.

(There's probably more places we can generalize still, but I'd rather keep this moving and if need be, surgically make changes later)

@scolapasta scolapasta removed their assignment Apr 28, 2020
@kcondon kcondon self-assigned this Apr 29, 2020
@kcondon kcondon merged commit 5ffc7b0 into develop Apr 29, 2020
@kcondon kcondon deleted the 6593-payara-docs branch April 29, 2020 20:46
@djbrooke djbrooke added this to the Dataverse 5 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djbrooke djbrooke djbrooke left review comments

@scolapasta scolapasta scolapasta approved these changes

Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
Dataverse 5
Development

Successfully merging this pull request may close these issues.

Payara Documentation Updates
5 participants
@pdurbin @coveralls @scolapasta @djbrooke @kcondon