reorder links to get firefox to use larger favicon #6966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheppler
approved these changes
Jun 5, 2020
|
@qqmyers would you be so kind as to provide some screenshots? Have you confirmed this change does not effect other browsers? I am looking at the favicon in my browser tabs, and I can't tell if it's one size or another. The default Dataverse logo favicon used on the Harvard Dataverse (4.20, FF 68.9.0) looks sharp.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=751712
What this PR does / why we need it: works-around a firefox bug to display better favicon
Which issue(s) this PR closes:
Closes #6965
Special notes for your reviewer:
Suggestions on how to test this: Firefox only as far as I know. The code change is just to put the 32 pixel favicon line in the source after the 16 pixel one. So you can check the source. That should also change the favicon itself but that could potentially be cached in your browser.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: just shows better favicon
Is there a release notes update needed for this change?: no
Additional documentation: