Delete scripts/setup/asadmin-setup.sh #7049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, there are no usages of this script anymore. It uses Glassfish 4 and ancient Postgres 9.3. As it's the only file left in the directory, better remove it to avoid confusion.
michbarsinai
reviewed
Jul 2, 2020
There was a problem hiding this comment.
I don't think I'm up-to-date enough on the subject to have a useful opinion. Deferring to @pdurbin and @scolapasta
pdurbin
approved these changes
Jul 2, 2020
|
@michbarsinai thanks for weighing in. This script isn't actively used and would need to be updated to keep it in line with the scripts we do use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Apparently, there are no usages of this script anymore. It uses Glassfish 4 and ancient Postgres 9.3. As it's the only file left in the directory, better remove it to avoid confusion.
Which issue(s) this PR closes:
Opened this PR upon request by @pdurbin on IRC without opening an issue before.
Special notes for your reviewer:
Do you know of this script being actively used today?
Suggestions on how to test this:
Nada.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nada.
Is there a release notes update needed for this change?:
Nada.
Additional documentation:
Nada.