Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6919 preview tools #7311

Merged
merged 34 commits into from
Oct 27, 2020
Merged

6919 preview tools #7311

merged 34 commits into from
Oct 27, 2020

Commits on Aug 20, 2020

  1. Added static preview icon btn to file table on dataset pg, reviewed r…

    …eferences in guides to explore tools [ref #6919]
    mheppler committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    bee8880 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Added hasPreviewMode to example code in Admin Guide, added preview ic…

    …on btn to Style Guide [ref #6919]
    mheppler committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9a6c0c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Configuration menu
    Copy the full SHA
    78fb7df View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Configuration menu
    Copy the full SHA
    37afbce View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Configuration menu
    Copy the full SHA
    b142cc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Configuration menu
    Copy the full SHA
    e2d0caf View commit details
    Browse the repository at this point in the history
  2. #6919 preview mode logic

    sekmiller committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    8b2dcfd View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Configuration menu
    Copy the full SHA
    54bd1e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. fix formatting #6919

    pdurbin committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    5f102be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80fe764 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2fb03c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Configuration menu
    Copy the full SHA
    2c94148 View commit details
    Browse the repository at this point in the history
  2. selectively render preview/eyeball button #6919

    The rule is "The eyeball is present if the Preview tab is present."
    
    There are edge cases to consider around guestbook, terms of use,
    restricted data, etc.
    
    For now we at least check if the appropriate tools are in place.
    pdurbin committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    de01f35 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. remove binding and process=@this #6919

    Our goal is to include file-download-popup-fragment.xhtml onto another
    location, the Preview tab on the file page, while still displaying
    it as a popup on that page.
    
    In the Preview tab the input fields weren't showing up and we discovered
    that commenting out "binding" made them appear. Commenting out "binding"
    resulted in validation not working. Additionally removing process=@this
    along with much more refactoring, got validation working. Bean validation
    was added as well.
    
    The hope is that with this commit in place, we can switch back to trying
    to get the extra "include" (mentioned above) working.
    
    Some things to note about this commit:
    
    - Custom UIInput fields have been removed in favor of standard
    Bean Validation.
    - The GuestbookResponse field was removed from FileDownloadHelper because
    it was confusing to sometimes set it and other times pass it in as argument
    to various methods. Now we always pass it in.
    - Various unused code was deleted.
    - process=@this wasn't removed from the "package" code and it's unknown
    if that code is working.
    
    Conflicts:
    src/main/java/ValidationMessages.properties
    pdurbin committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    50f9018 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. show gb/terms on Preview tab, relax preview rules #6919

    This commit does two things:
    
    - Include file-download-popup-fragment.xhtml (where guestbook and terms live) on the Preview tab.
    - Allow files to be previewed in more scenarios, such as when datasets have a guestbook or terms.
    
    There are a couple TODO/FIXME items not addressed:
    
    - <p:focus context="downloadPopup"/> was commented out.
    - @Form is used in a place where it could be more precise.
    pdurbin committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    886cab8 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Fixed guestbook form focus issue, added external tool type render log…

    …ic to btn txt on file pg [ref #6919]
    mheppler committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    c509773 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Configuration menu
    Copy the full SHA
    2115b6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b34ca9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9a24283 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f8213ba View commit details
    Browse the repository at this point in the history
  5. expand "update" for validation #6919

    Without this update, the failure case was this:
    
    1. When there are required fields, click Accept without filling them in.
    2. Fill in all required fields and click Accept.
    3. The form remains and you cannot see the preview.
    pdurbin committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    55c6854 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'develop' into 6919-preview-tools #6919

    Conflicts:
    src/main/java/ValidationMessages.properties
    pdurbin committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    a6d32ff View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Configuration menu
    Copy the full SHA
    bff99b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. update docs for preview tools branch #6919

    Lots of edits were made previously in this branch.
    pdurbin committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    90f1673 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a42fa4d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e469cc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Configuration menu
    Copy the full SHA
    5696f5f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Configuration menu
    Copy the full SHA
    e5eacae View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Configuration menu
    Copy the full SHA
    767882b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b62d0d View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. remove validation checks we don't need #6919

    We've switched to Bean Validation, which is done centrally instead of
    being only in the UI.
    pdurbin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    e73d2f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    132e1ee View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. #6919 remove unused code

    sekmiller committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a82d839 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b6c0778 View commit details
    Browse the repository at this point in the history