-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6919 preview tools #7311
6919 preview tools #7311
Commits on Aug 20, 2020
-
Added static preview icon btn to file table on dataset pg, reviewed r…
…eferences in guides to explore tools [ref #6919]
Configuration menu - View commit details
-
Copy full SHA for bee8880 - Browse repository at this point
Copy the full SHA bee8880View commit details
Commits on Aug 21, 2020
-
Added hasPreviewMode to example code in Admin Guide, added preview ic…
…on btn to Style Guide [ref #6919]
Configuration menu - View commit details
-
Copy full SHA for 9a6c0c9 - Browse repository at this point
Copy the full SHA 9a6c0c9View commit details
Commits on Aug 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 78fb7df - Browse repository at this point
Copy the full SHA 78fb7dfView commit details
Commits on Aug 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 37afbce - Browse repository at this point
Copy the full SHA 37afbceView commit details
Commits on Aug 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b142cc5 - Browse repository at this point
Copy the full SHA b142cc5View commit details
Commits on Aug 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e2d0caf - Browse repository at this point
Copy the full SHA e2d0cafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b2dcfd - Browse repository at this point
Copy the full SHA 8b2dcfdView commit details
Commits on Sep 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 54bd1e3 - Browse repository at this point
Copy the full SHA 54bd1e3View commit details
Commits on Sep 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5f102be - Browse repository at this point
Copy the full SHA 5f102beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80fe764 - Browse repository at this point
Copy the full SHA 80fe764View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2fb03c - Browse repository at this point
Copy the full SHA a2fb03cView commit details
Commits on Sep 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2c94148 - Browse repository at this point
Copy the full SHA 2c94148View commit details -
selectively render preview/eyeball button #6919
The rule is "The eyeball is present if the Preview tab is present." There are edge cases to consider around guestbook, terms of use, restricted data, etc. For now we at least check if the appropriate tools are in place.
Configuration menu - View commit details
-
Copy full SHA for de01f35 - Browse repository at this point
Copy the full SHA de01f35View commit details
Commits on Sep 25, 2020
-
remove binding and process=@this #6919
Our goal is to include file-download-popup-fragment.xhtml onto another location, the Preview tab on the file page, while still displaying it as a popup on that page. In the Preview tab the input fields weren't showing up and we discovered that commenting out "binding" made them appear. Commenting out "binding" resulted in validation not working. Additionally removing process=@this along with much more refactoring, got validation working. Bean validation was added as well. The hope is that with this commit in place, we can switch back to trying to get the extra "include" (mentioned above) working. Some things to note about this commit: - Custom UIInput fields have been removed in favor of standard Bean Validation. - The GuestbookResponse field was removed from FileDownloadHelper because it was confusing to sometimes set it and other times pass it in as argument to various methods. Now we always pass it in. - Various unused code was deleted. - process=@this wasn't removed from the "package" code and it's unknown if that code is working. Conflicts: src/main/java/ValidationMessages.properties
Configuration menu - View commit details
-
Copy full SHA for 50f9018 - Browse repository at this point
Copy the full SHA 50f9018View commit details
Commits on Sep 30, 2020
-
show gb/terms on Preview tab, relax preview rules #6919
This commit does two things: - Include file-download-popup-fragment.xhtml (where guestbook and terms live) on the Preview tab. - Allow files to be previewed in more scenarios, such as when datasets have a guestbook or terms. There are a couple TODO/FIXME items not addressed: - <p:focus context="downloadPopup"/> was commented out. - @Form is used in a place where it could be more precise.
Configuration menu - View commit details
-
Copy full SHA for 886cab8 - Browse repository at this point
Copy the full SHA 886cab8View commit details
Commits on Oct 2, 2020
-
Fixed guestbook form focus issue, added external tool type render log…
…ic to btn txt on file pg [ref #6919]
Configuration menu - View commit details
-
Copy full SHA for c509773 - Browse repository at this point
Copy the full SHA c509773View commit details
Commits on Oct 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2115b6d - Browse repository at this point
Copy the full SHA 2115b6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b34ca9 - Browse repository at this point
Copy the full SHA 2b34ca9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a24283 - Browse repository at this point
Copy the full SHA 9a24283View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8213ba - Browse repository at this point
Copy the full SHA f8213baView commit details -
expand "update" for validation #6919
Without this update, the failure case was this: 1. When there are required fields, click Accept without filling them in. 2. Fill in all required fields and click Accept. 3. The form remains and you cannot see the preview.
Configuration menu - View commit details
-
Copy full SHA for 55c6854 - Browse repository at this point
Copy the full SHA 55c6854View commit details -
Merge branch 'develop' into 6919-preview-tools #6919
Conflicts: src/main/java/ValidationMessages.properties
Configuration menu - View commit details
-
Copy full SHA for a6d32ff - Browse repository at this point
Copy the full SHA a6d32ffView commit details
Commits on Oct 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bff99b3 - Browse repository at this point
Copy the full SHA bff99b3View commit details
Commits on Oct 7, 2020
-
update docs for preview tools branch #6919
Lots of edits were made previously in this branch.
Configuration menu - View commit details
-
Copy full SHA for 90f1673 - Browse repository at this point
Copy the full SHA 90f1673View commit details -
Configuration menu - View commit details
-
Copy full SHA for a42fa4d - Browse repository at this point
Copy the full SHA a42fa4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e469cc4 - Browse repository at this point
Copy the full SHA e469cc4View commit details
Commits on Oct 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5696f5f - Browse repository at this point
Copy the full SHA 5696f5fView commit details
Commits on Oct 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e5eacae - Browse repository at this point
Copy the full SHA e5eacaeView commit details
Commits on Oct 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 767882b - Browse repository at this point
Copy the full SHA 767882bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b62d0d - Browse repository at this point
Copy the full SHA 6b62d0dView commit details
Commits on Oct 26, 2020
-
remove validation checks we don't need #6919
We've switched to Bean Validation, which is done centrally instead of being only in the UI.
Configuration menu - View commit details
-
Copy full SHA for e73d2f4 - Browse repository at this point
Copy the full SHA e73d2f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 132e1ee - Browse repository at this point
Copy the full SHA 132e1eeView commit details
Commits on Oct 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a82d839 - Browse repository at this point
Copy the full SHA a82d839View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6c0778 - Browse repository at this point
Copy the full SHA b6c0778View commit details