Iqss/7335 change name when replacement name conflicts with other files #7336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
approved these changes
Oct 21, 2020
|
This branch needs to be updated with the latest from dev before it can go to QA, but that is all it needs |
…e_when_replacement_name_conflicts_with_other_files
|
@qqmyers assigning to you to update from dev |
…e_when_replacement_name_conflicts_with_other_files
affects error messages
…e_when_replacement_name_conflicts_with_other_files
…e_when_replacement_name_conflicts_with_other_files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Prevents duplicate names if a replacement file has the same name as some other file (on it isn't replacing) in the dataset
Which issue(s) this PR closes:
Closes #7335
Special notes for your reviewer:
Suggestions on how to test this: There's a new test and it passes! The new part is if you replace file1 and give it the name of file2, you'll see the normal "_1" appended. If you replace file1 and use the same name as file 1, the name won't change.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: