Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added js+css to get the checksum to display in Bootstrap tooltips #7580

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

mheppler
Copy link
Contributor

@mheppler mheppler commented Feb 4, 2021

What this PR does / why we need it:

Kevin pointed out the delayed display of the full checksum in the default browser title hover, as compared to the smooth Bootstrap tooltips commonly used in the UI. Couldn't argue that astute observation, especially when he was willing to investigate workarounds in Stack Overflow.

With a wee bit of extra JS and some additional massaging of the HTML, got the tooltips displaying the checksums with word-break CSS to make sure they're not breaking out of the tooltip width.

Which issue(s) this PR closes:

Closes # N/A

[ref #7081, #6685, #5210]

Special notes for your reviewer:

Enjoy.

Suggestions on how to test this:

You know what to do. Thanks for the help investigating solutions.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes. No mockups.

Is there a release notes update needed for this change?:

Additional documentation:

@kcondon kcondon self-assigned this Feb 4, 2021
@kcondon
Copy link
Contributor

kcondon commented Feb 4, 2021

Looks good! @mheppler need to give @scolapasta credit for finding the workarounds though.

@kcondon kcondon merged commit 4371725 into develop Feb 4, 2021
@kcondon kcondon deleted the checksum-tooltips-redux branch February 4, 2021 17:37
@djbrooke djbrooke added this to the 5.4 milestone Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants