6953 mpconfig context param #7695
Conversation
poikilotherm
added
Type: Feature
poikilotherm
force-pushed
the
6953-mpconfig-context-param
branch
from
6102e1a to
295636a
Compare
poikilotherm
force-pushed
the
6953-mpconfig-context-param
branch
from
295636a to
617592f
Compare
poikilotherm
changed the title
…l and a docs hint. IQSS#6953
…yara 5.2020.6 IQSS#6953 Reverts commit ca35411 Due to the nature of the application server, when the web app context is initialised, it cannot yet access the deployments default MPCONFIG source within META-INF/microprofile-config.properties. As a consequence, as long as we do not update to Payara 5.2021.1, we cannot provide sane defaults within the variable. That means that every installation would need to set the variables in MPCONFIG sources available at startup time and before the deployment finished: any are possible that are baked into Payara. As this doesn't seem feasible, this PR will be blocked until IQSS#7700 is resolved.
|
As this relies on Payara 5.2021.1 (see 48d6501 for an extensive explanation), I will put this back to draft. |
|
As #7701 is likely to be merged soonish, pushing this PR back into the pipeline. |
|
It looks like pull request #7701 is a little more involved than we originally thought and since it's a dependency (and since the Review column is pretty full), let's leave this in Community Dev until that other pull request is merged. |
|
Putting this back in Review now... |
|
Thanks @poikilotherm, we'll review. You mentioned two release notes in the PR description but I only saw one in the changed files - is there one missing or was the second release note handled elsewhere? |
|
Looks like a leftover. Just ignore that... Thx! |
There was a problem hiding this comment.
@poikilotherm I'm so happy for this pull request. In the years since 5f99037 I've had to maintain a local edit to src/main/webapp/WEB-INF/web.xml and be careful not to commit it to git in order to for my edits to the GUI to be visible. Now, it's just a simple change to domain.xml, which I added to the docs and the "rebuild" script (using asadmin).
What this PR does / why we need it:
This allows for a very dynamic changing of JSF parameters without recompilation. It adds docs how to do this, too.
This PR also relies on the fact that people should upgrade from Payara 5.2020.6 or later to at least 5.2021.1 to gain support for MPCONFIG 2.0 and default parametes in
${MPCONFIG=...}variable substitution, which is described in #7701Which issue(s) this PR closes:
Closes #6953
⚡ Blocked by #7701 ⚡
Special notes for your reviewer:
None.
Suggestions on how to test this:
Change some of the documented vars e. g. via system properties.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
Yes, two. 🔋 included.
Additional documentation:
None.