build(ci): atempt to fix coveralls report. #7977 #7981
Conversation
poikilotherm
force-pushed
the
7977-fix-coveralls
branch
from
7ec91f8 to
1fc42ad
Compare
|
This PR fixes the problem for pull requests. See https://coveralls.io/builds/40999007 It might be still broken for pushes, also it works at https://github.com/common-workflow-language/cwlviewer. No way to test that but merge this and see what happens. |
There was a problem hiding this comment.
@poikilotherm thank you for this pull request! 🎉
It's along the lines I expected, based on posts I've seen.
I'm a little confused about one thing though...
In the pull request we see this:
-DrepoToken=${COVERALLS_SECRET}
Instead, should this be...
-DrepoToken=${COVERALLS_TOKEN}
... to match the secret we set up in pull request #7944? Here's a screenshot I just took:
I'm confused about this because I can see that https://coveralls.io/github/IQSS/dataverse was updated this morning (the first time in a couple weeks) so whatever you're doing seems to be working:
There was a problem hiding this comment.
In Matrix @poikilotherm explained that we don't need COVERALLS_TOKEN in https://github.com/IQSS/dataverse/settings/secrets so I deleted it.
What's used instead is the GitHub token (COVERALLS_SECRET: ${{ secrets.GITHUB_TOKEN }}).
Thanks again for the pull request, @poikilotherm
@kcondon like pull request #7944 this one should be safe to merge without any real testing. We just want to see if https://coveralls.io/github/IQSS/dataverse starts updating automatically again or not afterwards.
|
Thanks for merging @kcondon ! 😄 |
What this PR does / why we need it:
This PR should finally resolve the coveralls report problem.
Which issue(s) this PR closes:
Closes #7977
Special notes for your reviewer:
None
Suggestions on how to test this:
None
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope
Is there a release notes update needed for this change?:
Nope
Additional documentation:
None