Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251 refactor api tests #8254

Closed
wants to merge 39 commits into from

Commits on Nov 22, 2021

  1. Configuration menu
    Copy the full SHA
    bbc802b View commit details
    Browse the repository at this point in the history
  2. feat(api-test): add JUnit5 Tags into helpers package IQSS#8251

    This will allow for a standardized collection of Strings
    thus avoid typos
    poikilotherm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    414f8e0 View commit details
    Browse the repository at this point in the history
  3. feat(api-test): add new JUnit5 extension @DBSetting IQSS#8251

    This extension allows to set and reset database settings within
    a target Dataverse instance. It will make sure to reset to
    old setting or remove the setting if not set before the test.
    
    This was introduced for three reasons:
    1. Don't execute a test if the setting did not go through
    2. Don't forget to reset or remove to keep a consistent state after a
       test execution
    3. Make the code more readable, as setting the setting has been part of
       the test before (which is bad design and might go booboo, see 2)
    poikilotherm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    45ae750 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ab8609 View commit details
    Browse the repository at this point in the history
  5. fix(api-test): make DatasetsIT not fail tests when no stored procedure

    …IQSS#8251
    
    When no stored procedure has been set up in the instance under test,
    test running after
    DatasetsIT.testStoredProcGeneratedAsIdentifierGenerationStyle() failed,
    as the database setting was never reverted.
    
    Making use of the new @DBSetting extension helps with that.
    poikilotherm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    e34d71e View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. feat(api-test): add JUnit5 extension for RandomUser IQSS#8251

    Many API tests require the use of a random user, which is no SuT
    (subject under test). To gather such a user and ensure its deletion
    from a target Dataverse instance after a test, this extension
    provides a convenient way. Simple use ExtendWith and provide a
    RandomUser parameter, you're done.
    poikilotherm committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    4b3a941 View commit details
    Browse the repository at this point in the history
  2. feat(api-test): create storage helper for JUnit 5 extensions IQSS#8215

    This helper class tries to abstract the store retrieval and handles all
    the tiny details on retrieving in-depth context for a store.
    poikilotherm committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    b19f8f5 View commit details
    Browse the repository at this point in the history
  3. feat(api-test): enhance RandomUserExtension IQSS#8251

    With this commit, the RandomUserExtension may be used on
    a test class, @BeforeEach/All, @AfterEach/All methods and
    test methods.
    
    It will take care of deletion in the appropriate ways to ensure a
    healthy target environment.
    
    Using it on @AfterEach/All will return the formerly created user via
    @BeforeEach/All and enabled aftermath reuse of the user.
    poikilotherm committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    6f7d96b View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. changed handleCommandClick() to call isRequestAccessPopupRequired() s…

    …o that only the terms of use and access are considered (and not the guestbook which should only be considered at file download in isDownloadPopupRequired).
    mdmADA authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    c1dceb6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8f1d28 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9085bf3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6c4b7e3 View commit details
    Browse the repository at this point in the history
  5. allow Tika to detect content type when not supplied IQSS#8241

    "application/octet-stream" is the default when the user doesn't supply a
    content type. So if it's this, send it through Tika. Yes, a user
    can supply "application/octet-stream" and this will also be sent through
    Tika.
    pdurbin authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    17a4c49 View commit details
    Browse the repository at this point in the history
  6. skip validation when embargo isn't enabled.

    This avoids an NPE when the empty embargo (from the dialog that isn't
    shown) is found to be invalid and then getMaxDate() returns null and the
    code tries to format it for display in the error message (which also
    wouldn't show).
    qqmyers authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    cbcb7cf View commit details
    Browse the repository at this point in the history
  7. IQSS#8272 explicitly init Postgres DB with UTF-8 encoding, bump Maven…

    … to 3.8.4
    don.sizemore authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    eba6d08 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    804b908 View commit details
    Browse the repository at this point in the history
  9. missing anoymization in files version table for anon PrivateURLs

    verified that the names withheld bundle entry already exists.
    qqmyers authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    55824dc View commit details
    Browse the repository at this point in the history
  10. initial doc creation

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    da6bc21 View commit details
    Browse the repository at this point in the history
  11. in with the new out with the old

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    17dddce View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    853572d View commit details
    Browse the repository at this point in the history
  13. resolving warnings

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    7ddb375 View commit details
    Browse the repository at this point in the history
  14. gathering of the use cases

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    ae2dc8a View commit details
    Browse the repository at this point in the history
  15. updates

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    cc58428 View commit details
    Browse the repository at this point in the history
  16. more updates

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    af9a551 View commit details
    Browse the repository at this point in the history
  17. settings and dev guide updates.

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    e123cd9 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e7c263a View commit details
    Browse the repository at this point in the history
  19. feedback from @donsizemore

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    6efc0f5 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    7c1d83a View commit details
    Browse the repository at this point in the history
  21. adding analytics fix per @qqmyers

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    6947b77 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    771f63b View commit details
    Browse the repository at this point in the history
  23. review feedback

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    aef79d2 View commit details
    Browse the repository at this point in the history
  24. updates from review

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    8aedc79 View commit details
    Browse the repository at this point in the history
  25. Update 5.9-release-notes.md

    landreev authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    f07ad57 View commit details
    Browse the repository at this point in the history
  26. Update 5.9-release-notes.md

    landreev authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    fa3d22c View commit details
    Browse the repository at this point in the history
  27. review feedback, thanks @landreev

    djbrooke authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    f1282d6 View commit details
    Browse the repository at this point in the history
  28. Update conf.py

    Update to v5.9
    kcondon authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    45104dc View commit details
    Browse the repository at this point in the history
  29. Update versions.rst

    Update to v5.9
    kcondon authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    bf333c5 View commit details
    Browse the repository at this point in the history
  30. Update pom.xml

    Update to v5.9
    kcondon authored and poikilotherm committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    82f20a4 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    75aa5b9 View commit details
    Browse the repository at this point in the history