Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/8595 - update existing schema and code to make all cvv files multival in solr #8601

Merged
merged 3 commits into from
Apr 29, 2022
Merged

IQSS/8595 - update existing schema and code to make all cvv files multival in solr #8601

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f55578a
update existing schema and code to make all cvv files multival in solr
qqmyers Apr 12, 2022
1ee29e4
release note
qqmyers Apr 12, 2022
cbe1327
add ToDos re more efficient code
qqmyers Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conf/solr/8.11.1/schema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@
<field name="grantNumber" type="text_en" multiValued="true" stored="true" indexed="true"/>
<field name="grantNumberAgency" type="text_en" multiValued="true" stored="true" indexed="true"/>
<field name="grantNumberValue" type="text_en" multiValued="true" stored="true" indexed="true"/>
<field name="journalArticleType" type="text_en" multiValued="false" stored="true" indexed="true"/>
<field name="journalArticleType" type="text_en" multiValued="true" stored="true" indexed="true"/>
<field name="journalIssue" type="text_en" multiValued="true" stored="true" indexed="true"/>
<field name="journalPubDate" type="text_en" multiValued="true" stored="true" indexed="true"/>
<field name="journalVolume" type="text_en" multiValued="true" stored="true" indexed="true"/>
Expand Down
3 changes: 3 additions & 0 deletions doc/release-notes/8595-cvv-field-solr-update.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Controlled vocabulary fields that do not allow multiple entries are not indexed properly in Dataverse instances configured to support multiple languages. This release fixes the schema.xml file for the one field affected in the standard metadata blocks (journalArticleType) and updates the api/admin/index/solr/schema to provide the correct information for use with the update-fields.sh script described in the [Metadata Customization section of the Admin Guide](https://guides.dataverse.org/en/latest/admin/metadatacustomization.html#updating-the-solr-schema).

The release should include updating the schema.xml file for solr or running the update-fields.sh script and reindexing (whatever standard instructions we give for schema changes.)
2 changes: 1 addition & 1 deletion src/main/java/edu/harvard/iq/dataverse/DatasetFieldType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ public SolrField getSolrField() {

boolean makeSolrFieldMultivalued;
// http://stackoverflow.com/questions/5800762/what-is-the-use-of-multivalued-field-type-in-solr
if (allowMultiples || parentAllowsMultiplesBoolean) {
if (allowMultiples || parentAllowsMultiplesBoolean || isControlledVocabulary()) {
makeSolrFieldMultivalued = true;
} else {
makeSolrFieldMultivalued = false;
Expand Down