Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/8698 - fix bag-info.txt file creation #8699

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented May 16, 2022

What this PR does / why we need it: Updates 4 year old code associating a JSONLDTerm with the DatasetFieldType specified by name to also work for child fields - required since #8592.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: Configure to generate an archival bag, verify that it works and that the description text appears in the External-Description: in the included bag-info.txt file.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no - should be included in the same release as #8592

Additional documentation:

@qqmyers qqmyers added TDL of interest to the Texas Digital Library HDC: 3a Harvard Data Commons Obj. 3A GDCC: QDR of interest to QDR labels May 16, 2022
@qqmyers qqmyers added the HDC Harvard Data Commons label May 24, 2022
@coveralls
Copy link

coveralls commented May 24, 2022

Coverage Status

Coverage remained the same at 19.719% when pulling d531d9c on GlobalDataverseCommunityConsortium:IQSS/8698-fix_bag-info.txt_file_creation into 1df6b63 on IQSS:develop.

@kcondon kcondon merged commit 4d10da5 into IQSS:develop May 26, 2022
@pdurbin pdurbin added this to the 5.11 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GDCC: QDR of interest to QDR HDC Harvard Data Commons HDC: 3a Harvard Data Commons Obj. 3A TDL of interest to the Texas Digital Library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archival Bag-info.txt file fails after #8592
6 participants