Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oai_dc export: use publication date if production date is not set #8733

Merged
merged 5 commits into from
Oct 13, 2022

Conversation

tcoupin
Copy link
Member

@tcoupin tcoupin commented May 24, 2022

What this PR does / why we need it:

Production date is used as date tag when export dataset to oai_dc.
This PR use the publication date if production is not set.

Which issue(s) this PR closes:

Related to #8103 and #8732

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@scolapasta
Copy link
Contributor

Hi @tcoupin, for this next sprint we are catching up on Community PRs. Would you mind updating/ refreshing thiis PR from develop? Thanks!

@tcoupin
Copy link
Member Author

tcoupin commented Aug 4, 2022

I rebase on develop branch

@sekmiller sekmiller self-assigned this Sep 7, 2022
@coveralls
Copy link

coveralls commented Sep 13, 2022

Coverage Status

Coverage decreased (-0.0005%) to 19.88% when pulling 97cf6bc on tcoupin:oaidc-date into 9686ab8 on IQSS:develop.

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. thanks for the contribution and rebasing.

@sekmiller sekmiller removed their assignment Sep 14, 2022
@pdurbin pdurbin changed the title OAIDC export use publication date if prodcution date is not set oai_dc export: use publication date if production date is not set Oct 12, 2022
@pdurbin pdurbin merged commit 1daae04 into IQSS:develop Oct 13, 2022
@pdurbin
Copy link
Member

pdurbin commented Oct 13, 2022

Looks good! Merged! Thanks @sekmiller @jggautier and @landreev for the discussion.

At release time, @jggautier plans to update our crosswalk doc to explain the new date handling. I linked to the doc in the release note snippet I added: 97cf6bc

We also discussed a bit how the oai_dc format is not available in the dropdown as an export. However you can hack the URL to get to it: https://dataverse.harvard.edu/api/datasets/export?exporter=oai_dc&persistentId=doi%3A10.7910/DVN/TJCLKP . If we ever want to change this, it's just a matter of flipping the isAvailableToUsers boolean in DublinCoreExporter:

https://github.com/IQSS/dataverse/blob/v5.12/src/main/java/edu/harvard/iq/dataverse/export/DublinCoreExporter.java#L52-L54

Anyway, thanks, @tcoupin! Please keep the pull requests coming! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants