8832 toa validation error on ds create #8834
Conversation
src/main/webapp/dataset.xhtml
Outdated
| try{ | ||
| termsofAccessHidden = document.getElementById("datasetForm:tabView:termsofAccessHiddenLT").value; | ||
| fileAccessRequestHidden = document.getElementById("datasetForm:tabView:fileAccessRequestHiddenLT").value; | ||
| } | ||
| catch (error){ | ||
| alert("notdatasetform"); |
There was a problem hiding this comment.
this seems like it should not be here :)
There was a problem hiding this comment.
good catch, thanks
| @@ -422,6 +422,14 @@ public Boolean isHasRestrictedFiles(){ | |||
| } | |||
| } | |||
|
|
|||
| public boolean getHasRestrictedFiles(){ | |||
There was a problem hiding this comment.
I dont think you need this - being a boolean it should call the isHasRastrictedFiles method. But see my other note for if we even need the ui:hidden field.
|
It's now working with the minor exception of the string showing 0 restricted files once there are terms of access but no restricted files. The terms of access in this case have not been rendered by the file count remains. From the user who reported it: |
What this PR does / why we need it: Fixes the Terms of Access validator to notice when there are no restricted files in the Dataset version
Which issue(s) this PR closes:
Closes #8832 Problem with license selection and Terms of Access/Enable access request button
Closes #8847
Special notes for your reviewer:
Suggestions on how to test this: Make sure you can update the terms of use/license in a dataset that doesn't have restricted files. also verify that adding/editing templates Terms still works.
Also there is a minor ui change - see 8847 where terms of access won't be shown on the terms display tab if there are no restricted files.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: none
Additional documentation:none