Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8735 fix edit fields #8837

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

sekmiller
Copy link
Contributor

@sekmiller sekmiller commented Jul 12, 2022

What this PR does / why we need it: IF you add a custom metadata block to a dataverse that already has a template, when you edit that template the new meatdata block is not available for adding default values. This PR allows you to add default values to the newly added MDB.

Which issue(s) this PR closes:

Closes #8735 New Metadata blocks not appearing in previously created templates.

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no

Additional documentation: none

@pdurbin pdurbin self-assigned this Jul 15, 2022
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run the code but the fix looks fine to me. Nothing weird in here and some nice cleanup.

@pdurbin pdurbin removed their assignment Jul 15, 2022
@kcondon kcondon self-assigned this Jul 15, 2022
@kcondon kcondon merged commit c638e10 into develop Jul 15, 2022
@kcondon kcondon deleted the 8735-new-mdbs-not-shown-in-prior-templates-on-edit branch July 15, 2022 19:20
@pdurbin pdurbin added this to the 5.12 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New metadata blocks not appearing in previously created templates
3 participants