IQSS/8730 - fix direct upload progress #8962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss_for_direct_uploads
…ss_for_direct_uploads
…ss_for_direct_uploads
|
added to sprint Dec 15, 2022 |
scolapasta
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Direct upload via the UI sends up to 4 files at a time and their progress bars are all changing at the same time. The old code would update all progress bars during the hash calculation phase rather than only the bar for the current file.
Which issue(s) this PR closes:
Closes #8730
Special notes for your reviewer:
Suggestions on how to test this: upload a mix of small and large files (< MB up to 100 MB+) and assure that when the larger file(s) are showing progress above 50%, the smaller progress bars aren't jumping up/down. It may be easier to see if you set the network to be throttled in the browser dev console to limit how fast bytes are transferred (e.g. fast 3G or even slow 3G).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: