Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/7349-4 creator updates in schema.org #9089

Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0b375cf
add type for person/org, add sameas, fix affiliation
qqmyers Oct 18, 2022
5bd58d8
typo
qqmyers Oct 18, 2022
63cd77d
capitalization
qqmyers Oct 19, 2022
8084fb8
update tests
qqmyers Oct 19, 2022
489d0e3
legacy test issue
qqmyers Oct 19, 2022
c3260a5
change fullname -> fullName
qqmyers Oct 19, 2022
3ddc796
note todos
qqmyers Oct 19, 2022
05ea63a
add tests
qqmyers Oct 19, 2022
6ca9f70
don't send giveName for orgs
qqmyers Oct 19, 2022
a5fafd0
release note
qqmyers Oct 19, 2022
f222160
bugfix for no givenName/familyName from algorithm
qqmyers Oct 20, 2022
41c30d9
add assumeCommaInPersonName and tests
qqmyers Oct 21, 2022
d5d3655
update docs/release note
qqmyers Oct 21, 2022
ebb1380
added org Phrases for DANS
qqmyers Oct 28, 2022
4dcd8ed
fix affiliation value (no parens)
qqmyers Oct 28, 2022
0184b3d
logic fix
qqmyers Oct 28, 2022
545a295
comma check shouldn't override isPerson
qqmyers Oct 28, 2022
ab2326c
always set givenName null for Org
qqmyers Oct 28, 2022
0d54106
optimize - break out of loop when done
qqmyers Oct 28, 2022
1d935fe
documentation of new options
qqmyers Oct 28, 2022
a5ae4d7
add labels
qqmyers Oct 28, 2022
ab7bb33
Merge remote-tracking branch 'IQSS/develop' into IQSS/7349-4_creator_…
qqmyers Nov 7, 2022
4bec5f6
merge
qqmyers Dec 14, 2022
839376d
Merge remote-tracking branch 'IQSS/develop' into IQSS/7349-4_creator_…
qqmyers Jan 20, 2023
ec10bad
Merge remote-tracking branch 'IQSS/develop' into IQSS/7349-4_creator_…
qqmyers Jan 30, 2023
216fb8a
Merge remote-tracking branch 'IQSS/develop' into
qqmyers Jan 31, 2023
863be65
merge fixes
qqmyers Jan 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't send giveName for orgs
it does not appear to be useful given the tests in PersonOrOrgUtilTest
  • Loading branch information
qqmyers committed Oct 19, 2022
commit 6ca9f7099698bcfe08f6fbc98379f3f989d6a283
Original file line number Diff line number Diff line change
@@ -44,6 +44,7 @@ public static JsonObject getPersonOrOrganization(String name, boolean organizati
}
} else if (isOrganization || organizationIfTied) {
isOrganization = true;
givenName=null;
}

} else {
@@ -58,6 +59,7 @@ public static JsonObject getPersonOrOrganization(String name, boolean organizati
// default
if (isOrganization || organizationIfTied) {
isOrganization = true;
givenName=null;
}
}
}