8932 - fix pushing to Docker Hub #9236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker Login Actions do not enable logging in to docker.io, but a standard registry. By not overriding the registry, Docker Maven Plugin will use the one supplied by Docker context (which the authorization was done for by docker/login-action)
poikilotherm
added
the
Component: Containers
|
@mreekie @pdurbin this is VERY small and a fix for a slipped through bug. I very much believe it will not be necessary to give this more attention than 5 minutes to simply merge it, as there is not very much to review nor test nor QA. I will nonetheless give this a "Size: 3" label. I would be glad if you folks could "just merge" to make the larger idea of #8932 a success story. Thank you! |
pdurbin
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Docker Login Actions do not enable logging in to docker.io, but a standard registry. By not overriding the registry, Docker Maven Plugin will use the one supplied by Docker context.
This is basically a typo and was tested with https://github.com/poikilotherm/dataverse/tree/test-8933 to identify the causing issue.
Which issue(s) this PR closes:
Closes #8932
Special notes for your reviewer:
This is a "typo" and took some debugging. Not sure this needs deeper reviewing.
Suggestions on how to test this:
Was tested with a feature branch, as mentioned above. The failing action could be reproduced to fail in the feature branch action and the ONLY difference is the additional option.
Not sure what else should be tested.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
Nope, this is a type, the main PR had a release note.
Additional documentation:
None.