External Exporters bug fix #9632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
approved these changes
May 31, 2023
|
I'm just mentioning which test is failing and how: Expected status code <200> doesn't match actual status code <at edu.harvard.iq.dataverse.api.DatasetsIT.testCuratePublishedDatasetVersionCommand(DatasetsIT.java:2787) From here, for example: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9493/4/testReport/edu.harvard.iq.dataverse.api/DatasetsIT/testCuratePublishedDatasetVersionCommand/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: When there is no weight variable (which is tested in an IT test but not a unit test), the code give an NPE. This PR checks for a null response in getWeghtvariable() to avoid that.
This is a quick follow-up to #9175 which was merged before the IT test failure was noticed.
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer:
Suggestions on how to test this: Let the IT tests run/succeed.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: