Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the .gitattributes file so it can make it easier for Windows u… #9895

Closed
wants to merge 1 commit into from
Closed

Conversation

jp-tosca
Copy link
Contributor

@jp-tosca jp-tosca commented Sep 8, 2023

What this PR does / why we need it:

Adding the .gitattributes file so it can make it easier for Windows users to get going on the code by just adding a file to the Git repository.

Which issue(s) this PR closes:

Special notes for your reviewer:

https://groups.google.com/g/dataverse-community/c/dGduT2T8F7Y

Suggestions on how to test this:

Download the project from the original repo
Create a windows installation and set the core.autocrlf to false.
The development of the containers should fail.
Delete the instalation
Set core.autocrlf=input to input or true
The development of the containers should be successful.
set the core.autocrlf to false again
download from this fork
the development should be successful

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No

Is there a release notes update needed for this change?:
Change on the documentation at https://guides.dataverse.org/en/latest/developers/windows.html this step would not be necessary

Additional documentation:
https://www.git-scm.com/docs/gitattributes

…sers to get going on the code by just adding a file to the Git repository.
@pdurbin
Copy link
Member

pdurbin commented Sep 8, 2023

@jp-tosca thanks for the pull request!

While you're in here, would you be able to hack on https://github.com/jp-tosca/9894-gitattributes-add/blob/develop/doc/sphinx-guides/source/developers/windows.rst and add anything you think would be helpful to Windows developers?

We are very Mac-heavy at IQSS so we don't have a great understanding of the Windows world! 😅

Also, dumb question. To test this I need a Windows box, right? I'm on a Mac.

@jp-tosca
Copy link
Contributor Author

jp-tosca commented Sep 8, 2023

Thanks @pdurbin for sure I will get more familiar with the Dataverse and add as much as I can for Windows development.

You know what they say right? "The only dumb question is the one we don't ask". Yes, a Windows installation would be necessary for testing, I am not sure what is the current situation with Windows on Mac since I think they can't boot Windows since the new chip came out (I am probably wrong) but in the past, I used to use something called parallels to run windows on Mac.

I also can stop by the center one of these days and bring my machine 😅

@jp-tosca
Copy link
Contributor Author

@pdurbin Was checking this fork

@jp-tosca jp-tosca closed this Sep 12, 2023
@pdurbin
Copy link
Member

pdurbin commented Sep 12, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for .gitattributes file to handle CRLF vs LF for SH Files
2 participants