#9940 - fixed various issues with generated urls of authors for signposting #9941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
approved these changes
Sep 20, 2023
| if (authorURL != null && !authorURL.isBlank()) { | ||
| // return empty if number of visible author more than max allowed | ||
| // >= since we're comparing before incrementing visibleAuthorCounter | ||
| if (visibleAuthorCounter >= maxAuthors) { | ||
| if (limit && visibleAuthorCounter >= maxAuthors) { |
There was a problem hiding this comment.
Nice catch - we had a limit param and didn't use it!
pdurbin
added
the
Feature: Signposting
|
2923/12/13 |
|
2024/01/08: Moved into sprint read during prioritization meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Suggestions on how to test this:
I tested a lot of cases, I suggest the same approach :
Is there a release notes update needed for this change?:
I would say yes