Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency torch to v2.1.1 - autoclosed #329

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 5, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
torch 2.0.0 -> 2.1.1 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/torch-2.x-lockfile branch 9 times, most recently from 9c20d57 to 79f5a8d Compare October 10, 2023 15:38
@rashley-iqt
Copy link
Member

This issue stems from a difference in how pytorch and poetry are handling metadata in accordance with PEP 658.

Pytorch is currently packaged with per artifact metadata which breaks poetry's locking mechanism.

There seems to be a tentative agreement on how to solve the issue but it does not seem to be currently implemented in pytorch's build process. Until this is resolved we can:

  • reject pytorch versions greater than 2.0.0
  • use poetry's export command to generate a requirements.txt file and install dependencies using pip

The first option is the simplest, but is unsustainable in the longer term. The second option will require a non-trivial effort to re-engineer our workflows and containers. We could conceivably set the workflows and docker builds up to look for an exception in the poetry build and then fall back to generating and then installing from a requirements.txt file, but i don't like that pattern as it will still leave broken installs for users of poetry virtual environments. If this continues to be an issue we may need to look for an alternate packaging mechanism.

@renovate renovate bot force-pushed the renovate/torch-2.x-lockfile branch 2 times, most recently from a0e292b to b4c63f8 Compare October 16, 2023 14:20
@renovate renovate bot force-pushed the renovate/torch-2.x-lockfile branch 11 times, most recently from cf7627d to cd5618d Compare October 27, 2023 13:53
@renovate renovate bot force-pushed the renovate/torch-2.x-lockfile branch 5 times, most recently from 09f52ae to 0956f67 Compare November 9, 2023 16:11
@renovate renovate bot force-pushed the renovate/torch-2.x-lockfile branch 2 times, most recently from 9fce403 to aded1d1 Compare November 13, 2023 16:27
@renovate renovate bot changed the title Update dependency torch to v2.1.0 Update dependency torch to v2.1.1 Nov 15, 2023
@renovate renovate bot force-pushed the renovate/torch-2.x-lockfile branch from aded1d1 to d9f96bc Compare November 15, 2023 19:40
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b764101) 64.32% compared to head (d9f96bc) 64.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   64.32%   64.32%           
=======================================
  Files          32       32           
  Lines        3964     3964           
=======================================
  Hits         2550     2550           
  Misses       1414     1414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title Update dependency torch to v2.1.1 Update dependency torch to v2.1.1 - autoclosed Nov 23, 2023
@renovate renovate bot closed this Nov 23, 2023
@renovate renovate bot deleted the renovate/torch-2.x-lockfile branch November 23, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant