Fix for dev stringr

[hadley]

Where str_view() now prefers a console display that uses cli for colouring

[flying-sheep]

Doesn’t work with the current version:

Error in `stringr::str_view("xy", "y", html = TRUE)`: unused argument (html = TRUE)

So either repr has to wait for the new stringr to get released (which would result in temporary breakage) or we make the code forward compatible without breaking compatibility with the current version.

You could just do a patch release 1.4.2 for stringr that accepts html = TRUE and throws an error on html = FALSE, then we can change the dependency version of repr to >= 1.4.2 and release a forward-compatible repr version before stringr 1.5 comes out.

[hadley]

Sorry, the stringr dev version is so old, I'd forgotten that this argument wasn't in the CRAN version.

Given that this is in a test, and I presume you're just using str_view() since it's a simple HTML widget, are you ok with just a version switch?

[flying-sheep]

Ah right, didn’t notice this was just tests!

Sure, I’ll merge this once the new version is out, if that happens soon enough that I remember why I subscribed to tidyverse/stringr releases.

Thank you for helping out with the reverse deps!

[hadley]

This patch should work regardless of the version of stringr, so you can merge/release whenever.

I haven't official kicked off the stringr release process, but I'll ping this PR when I do (unless it's obvious that an updated repr is already on CRAN).

[hadley]

FYI stringr is now scheduled for release to CRAN on Dec 2.

[flying-sheep]

thank you for the info!