Makes explicit mention to TAR support #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge yet! Will add part to the mzml2isa.xml for Galaxy as well. |
|
I still need to add the changes to the test part of the galaxy wrapper... |
|
not sure... you could simply just print out on the terminal? Or you could upload artifacts to Amazon aws.... or perhaps with Dropbox |
|
You could use --test_output_text and print the output of the text file to the terminal. |
|
@RJMW can you reopen the pull request (maybe you thought that this was an issue by mistake), so that this can be merged eventually. Or is it that you don't want the functionality. |
|
Sorry! |
|
Thanks Ralf! No worries! |
Merged
|
Closing this now as it is resolved in the latest release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only to signal that, down the line, full_parse supports on this position both Zip and TAR files. Didn't want to change the argument name to avoid API changes, but you might want to consider that for a backwards incompatible release in the future.