Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpar editor #2

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Tpar editor #2

merged 9 commits into from
Sep 24, 2024

Conversation

rerpha
Copy link
Contributor

@rerpha rerpha commented Sep 17, 2024

No description provided.

Copy link
Contributor

@Chsudeepta Chsudeepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expected to also write some system tests for these changes?

@rerpha
Copy link
Contributor Author

rerpha commented Sep 19, 2024

Are we expected to also write some system tests for these changes?

we could do, but i think the ones in ioc test framework should be enough to cover what's needed? I didn't write one for writing a file, but could probably add one

@rerpha
Copy link
Contributor Author

rerpha commented Sep 23, 2024

jsut a note - we can't do anything about the switching window behaviour as it's a wider cs studio issue rather than specific to this. I have fixed the file saving if it hasnt changed, and have also fixed the line ending issue where it was putting extra line endings.

Copy link
Contributor

@Chsudeepta Chsudeepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected

@Chsudeepta Chsudeepta merged commit 837b1b3 into master Sep 24, 2024
@Chsudeepta Chsudeepta deleted the tpar_editor branch September 24, 2024 09:11
@Chsudeepta Chsudeepta restored the tpar_editor branch September 24, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants