Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket2808 gemorc commissioning #233

Merged
merged 6 commits into from
Feb 22, 2018

Conversation

AdrianPotter
Copy link
Contributor

@AdrianPotter AdrianPotter commented Feb 21, 2018

Description of work

Fix a few protocol and communication issues with the GEMORC following testing with the hardware

To test

ISISComputingGroup/IBEX#2808

Acceptance criteria

  • Issues raised in ticket are resolved
  • IOC test framework tests all still pass

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@Tom-Willemsen Tom-Willemsen merged commit 1f9c360 into master Feb 22, 2018
@Tom-Willemsen Tom-Willemsen deleted the Ticket2808_GEMORC_commissioning branch February 22, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants