Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and generalise TPG300 IOC #798

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Refactor and generalise TPG300 IOC #798

merged 4 commits into from
Aug 22, 2023

Conversation

boeuf-codes
Copy link
Contributor

@boeuf-codes boeuf-codes commented Jul 6, 2023

Description of work

  • Update IOC description to reflect support of the two 300/500 models
  • Add MODEL macro to reflect IOC TPG model
  • Add IPADDR macro to enable configuring a TPG500 via ethernet
  • Refactor which DBs to load depending on TPG model

To test

#7458

Acceptance criteria

List the acceptance criteria for the PR


Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@esmith1729 esmith1729 merged commit df74061 into master Aug 22, 2023
@esmith1729 esmith1729 deleted the Ticket7458 branch August 22, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants