Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEEDLE_VALVE_TOGGLE_WRITE macro #824

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

FreddieAkeroyd
Copy link
Member

Description of work

Add NEEDLE_VALVE_TOGGLE_WRITE macro to allow choice of whether files have write access toggled based on mode

To test

See ISISComputingGroup/IBEX#8175

Acceptance criteria

  • write access toggle can be disabled by macro

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@FreddieAkeroyd FreddieAkeroyd merged commit 1488b52 into master Jan 15, 2024
@FreddieAkeroyd FreddieAkeroyd deleted the Ticket8175_needle_valve_mode branch January 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant