-
Notifications
You must be signed in to change notification settings - Fork 1
Add necessary files for OPCUA ioc build #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
esmith1729
wants to merge
13
commits into
master
Choose a base branch
from
Ticket8586_add_OPCUA
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There's a lot of example code in this PR which makes it a bit tricky to review - could we cut down this IOC to the bits we're actually using? I think probably the entire
exampleTop
directory can go. - Please add some documentation on the wiki. I think we probably need two pages:
- One for OPCUA in general (e.g. write the documentation to help someone who is configuring a new OPCUA device on another instrument). Example topics:
- How is authentication being handled?
- Do any settings in the PLC side need adjusting to get communicating properly?
- Where are instrument-specific configs loaded from (looks like
opcua
folder in configs area, but please document this) - Where are instrument-specific DBs defined
- Any troubleshooting information you know of - e.g. what errors have you seen during the course of development and how were they resolved?
- As a supporter / on-call person, what would I need/want to know if I get a call saying communication with an OPCUA server isn't working?
- One for the MAPS vacuum system in particular, describing the operation/code behind the MAPS vacuum. No need to repeat the generic OPCUA IOC information here, link to the page above, just describe what is specific for MAPS' implementation.
- As a supporter / on-call person, what would I need/want to know if I get a call saying communication with MAPS' vacuum system isn't working?
- I think both of these pages are sub-pages under the
PLCs
section of the docs
- One for OPCUA in general (e.g. write the documentation to help someone who is configuring a new OPCUA device on another instrument). Example topics:
- Please add release notes
removed unnecessary shebang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
OPCUA IOC module that should be general purpose, for other OPC servers that need an IOC configuration.
OPCUA_01.cmd
should be placed inC:\Instrument\Settings\config\[instrument name]\configurations\opcua
folder, alongside a private key found on the network sharesTo test
Please confirm that this builds and runs correctly with the OPC PLC on MAPS, and that the OPCUA module looks accurately like other EPICS IOCs (this is my first time porting a new module to EPICS like this).
You will need to copy the
opcua\MAPS_OPCUA\
folder from the non-public shares into your config...\<NDW###\configurations\
copy and paste the folder there and name itopcua
so it can get pickup up by the IOC. Only copy theMAP_OPCUA
folder itself and rename it.MAPS: Provide support to read pressure values from vacuum PLC IBEX#8586
Acceptance criteria
MAPS-OPC-Server
Code Review
Functional Tests
..._0n
wheren>1
) run correctlymacLib: macro
to find instances ofmacLib: macro [macro name] is undefined...
Final steps