Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAE: add basic signals #9

Closed
Tom-Willemsen opened this issue Jul 30, 2024 · 1 comment · Fixed by #27
Closed

DAE: add basic signals #9

Tom-Willemsen opened this issue Jul 30, 2024 · 1 comment · Fixed by #27
Assignees
Labels

Comments

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Jul 30, 2024

As a user I would like access to various typically-used configuration signals on the DAE.

Most signals which are settable via the "DAE configuration" screen in IBEX, or readable as "interesting" PVs from the DAE, should be in scope.

For this issue, the signals need to be added to the DAE ophyd-async device, as either "standard" or "configuration" signals as appropriate for each signal.


In scope:

  • Most readable "interesting" float/int/str/enum PVs served directly from the DAE
    • Ensure this includes metadata like RB number, users, run number, ...
  • Most writeable configuration float/int/str/enum PVs served by the DAE.
  • Spectra, but limit to a single, constant "interesting" spectrum at a time for now
    • Prove we can read a spectra data array, don't worry about details of how it will be used in practice in this issue.

Out of scope (for this issue):

  • Derived signals (e.g. normalising intensity by monitor counts)
  • Filtered signals (e.g. regions-of-interest on spectra)
  • Anything that goes via areadetector (e.g. live view - this to be the subject of future issue(s))
  • Higher-level logic, e.g. the exact sequence of bluesky messages to begin/acquire/end a data point at the "top level".

Time in Planning

00:49:50 08/08/24

@KathrynBaker KathrynBaker moved this to Backlog in PI_2024_08 Aug 1, 2024
@Tom-Willemsen Tom-Willemsen added the 5 label Aug 8, 2024
@rerpha rerpha self-assigned this Aug 8, 2024
@rerpha
Copy link
Contributor

rerpha commented Aug 20, 2024

ISISComputingGroup/IBEX#8409 also add these PVs

@rerpha rerpha moved this from Review to In Progress in PI_2024_08 Sep 3, 2024
@Tom-Willemsen Tom-Willemsen self-assigned this Sep 5, 2024
@davidkeymer davidkeymer added the under review Issue is under review label Sep 19, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PI_2024_08 Sep 27, 2024
@KathrynBaker KathrynBaker removed the under review Issue is under review label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants