Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vertical and horizontal gap limits #1763

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chsudeepta
Copy link
Contributor

Description of work

Added fields to Jaws OPI to set the vertical and horizontal gap minimum limits.

Ticket

Ticket

Acceptance criteria

  • The OPI changes should provide separate fields for setting the minimum limits for horizontal and vertical gaps
  • The Jaws device screen should error out when vertical gap is less than minimum gap limit only when the direction of movement is reducing the gap from a previous higher value.
  • The Jaws device screen should error out when horizontal gap is less than minimum gap limit only when the direction of movement is reducing the gap from a previous higher value.
  • The corresponding motors should stop when minimum gap limits are violated.

Unit tests

The check_opi_format.py should be successful


Code Review

Final Steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant