Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front page prop #337

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Front page prop #337

merged 4 commits into from
Feb 24, 2024

Conversation

AbdiYus
Copy link
Contributor

@AbdiYus AbdiYus commented Feb 24, 2024

What has changed? ✨

  • Added frontprop component which takes props which are an image, title and color (optional logo).
  • Fixed text clipping on the front page
  • Mobile support

Old:

image

New:

image

How did you solve/implement it? 🧠

  • Just made a generic front component which has the elipse added.
  • If you want to have text over the elipse you should checkout the frontpage component.

@AbdiYus AbdiYus requested a review from Mosazghi as a code owner February 24, 2024 18:32
@vercel Vercel
Copy link

vercel bot commented Feb 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
startgjovik-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 10:55pm

@AbdiYus AbdiYus mentioned this pull request Feb 24, 2024
Closed
@Mosazghi Mosazghi merged commit d559e43 into development Feb 24, 2024
3 of 4 checks passed
@Mosazghi Mosazghi deleted the front-page-prop branch February 24, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mosazghi Mosazghi Awaiting requested review from Mosazghi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdiYus @Mosazghi