Fix trash #1
Merged
Fix trash #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In recent Jupyterlab-based services, including the ones created with the new cookiecutter for jupyterlabs, when the user deleted a file in the Jupyter UI, a
.Trash-1000folder is created. Given the permissions on this folder, we can't push it to S3. More details in ITISFoundation/osparc-issues#1296Investigations
It is not clear why this happens only in the newest Jupyters and not on other (e.g. jupyter-math). The "Trash" feature in jupyter seems relatively old (see jupyter/notebook#1968).
Solution
The JupyterLab Trash feature can be disabled via config. This is the only way I found to solve the issue, the only implication for the user is that if they delete a file via the UI, they won't be asked confirmation (it will work in the same way as deleting via the terminal with
rm).Services affected
Related issues
related to: ITISFoundation/osparc-issues#1296. All the services listed above need to be fixed to resolve the issue