Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

What do these changes do?

  • 🐛 [user request] Creating a template without data shouldn't complain about study size

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 20, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Imparable milestone Oct 20, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 20, 2025 14:54
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.10%. Comparing base (87a16bc) to head (558287b).

❗ There is a different number of reports uploaded between BASE (87a16bc) and HEAD (558287b). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (87a16bc) HEAD (558287b)
unittests 31 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8533      +/-   ##
==========================================
- Coverage   87.13%   81.10%   -6.03%     
==========================================
  Files        2010      782    -1228     
  Lines       79007    35540   -43467     
  Branches     1377      154    -1223     
==========================================
- Hits        68844    28826   -40018     
+ Misses       9764     6665    -3099     
+ Partials      399       49     -350     
Flag Coverage Δ
integrationtests 63.85% <0.00%> (-0.12%) ⬇️
unittests 81.29% <0.00%> (-4.90%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 75.16% <ø> (-9.43%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.65% <ø> (-12.67%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 82.00% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 82.13% <0.00%> (-4.59%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a16bc...558287b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 20, 2025 15:09
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2025

🧪 CI Insights

Here's what we observed from your CI run for 558287b.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Broken 0 View View

@sonarqubecloud
Copy link

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matusdrobuliak66 thx. It would be nice that we spot user-requests and highlight them in the release notes

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a template without data shouldn't complain about study size

6 participants