Progress on issue #482 show previous bookings for admin, PA and Liason: #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- General code cleanup. - Implement a function to fetch all bookings with pagination if the user is an admin, pa or liason. - Fix an issue with page permission where it wasn't changing after the user email and admins array were loaded.
lucia-gomez
reviewed
Nov 19, 2024
| walkedInAt: item.walkedInAt, | ||
| })); | ||
| setBookings(bookings); | ||
| setFutureBookings(fetchedData as Booking[]); |
| @@ -98,9 +103,12 @@ export const DatabaseProvider = ({ | |||
| const [userApiData, setUserApiData] = useState<UserApiData | undefined>( | |||
| undefined | |||
| ); | |||
| const [lastItem, setLastItem] = useState<any>(null); | |||
There was a problem hiding this comment.
can you type this instead of using any?
| setBookingsLoading(false); | ||
| }) | ||
| .catch((error) => console.error("Error fetching data:", error)); | ||
| }; | ||
|
|
||
| const fetchBookings = async () => { | ||
| try{ | ||
| const bookingsResponse : Booking[] = await fetchAllBookings(LIMIT, lastItem); |
There was a problem hiding this comment.
can you clarify what's happening here with LIMIT and lastItem? is there a reason we limit to 3?
There was a problem hiding this comment.
So we probably don't want to load all the previous bookings at the same time, I'm adding pagination here to load them in steps, the limit is just arbitrary we can change it to any number, or have a control for the admin to be able to change how many they would like to see at a time.
rlho
approved these changes
Nov 19, 2024
| export const getPaginatedData = async<T> ( | ||
| collectionName, | ||
| itemsPerPage = 10, | ||
| orderByField = 'calendarEventId', |
There was a problem hiding this comment.
we discussed it, and it's better to use requestedAt as the key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a function to fetch all bookings with pagination if the user is an admin, pa or liason.