Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KrylovKit compat upper bound to v0.8 #196

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

mofeing
Copy link
Contributor

@mofeing mofeing commented Sep 10, 2024

@mofeing
Copy link
Contributor Author

mofeing commented Sep 10, 2024

The documentation test failing is not an issue of this PR.

@JoeyT1994
Copy link
Contributor

Thanks! Yeah I think that test can be ignored for now

@mtfishman
Copy link
Member

I wonder why CompatHelper didn't make a PR for this...

@mtfishman
Copy link
Member

Ah, because it was disabled. I just enabled it again.

@mofeing
Copy link
Contributor Author

mofeing commented Sep 10, 2024

@mtfishman Should I close this pr then?

@mtfishman
Copy link
Member

We can merge this one and then CompatHelper can handle this kind of thing in the future.

@mtfishman mtfishman changed the title Update KrylovKit compat upper bound to v0.8 [ITensors] Update KrylovKit compat upper bound to v0.8 Sep 10, 2024
@mtfishman mtfishman merged commit 0ae30b1 into ITensor:main Sep 10, 2024
5 of 6 checks passed
@mtfishman
Copy link
Member

Thanks!

@mtfishman mtfishman changed the title [ITensors] Update KrylovKit compat upper bound to v0.8 Update KrylovKit compat upper bound to v0.8 Sep 10, 2024
@mofeing mofeing deleted the patch-1 branch September 10, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants