Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Remove Observers dependency #1379

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

emstoudenmire
Copy link
Collaborator

This PR introduces a simple package extension that defines ITensorMPS.update_observer! when the Observers package is loaded, and a simple test for it. It has been locally tested against the ITensorTDVP package also.

(Another attempt, making incremental changes to see what is breaking the tests. All tests pass locally but not in the CI.)

@emstoudenmire emstoudenmire changed the title Observers extension redo [ITensorMPS] Observers extension redo Apr 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (e8197ce) to head (c7025f8).

❗ Current head c7025f8 differs from pull request most recent head 519e3e5. Consider uploading reports for the commit 519e3e5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1379   +/-   ##
=======================================
  Coverage   79.59%   79.59%           
=======================================
  Files         114      114           
  Lines        9032     9032           
=======================================
  Hits         7189     7189           
  Misses       1843     1843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member

@emstoudenmire we could just merge this and then work on the extension in a followup, we may as well at least remove the dependency.

@emstoudenmire
Copy link
Collaborator Author

That sounds good. In the exten@ PR my plan is to make small changes until I get that Pkg bug again, to narrow down why. It's probably to do with Project.toml (maybe even the test/ did ones?) and maybe weak deps. We will see.

@mtfishman mtfishman changed the title [ITensorMPS] Observers extension redo [ITensors] Remove Observers dependency Apr 4, 2024
@mtfishman mtfishman merged commit 6fb2a5d into main Apr 4, 2024
17 checks passed
@mtfishman mtfishman deleted the observers_extension3 branch April 4, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants