Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright notation inconsistencies #8

Open
merkys opened this issue Feb 20, 2024 · 4 comments
Open

Copyright notation inconsistencies #8

merkys opened this issue Feb 20, 2024 · 4 comments
Labels

Comments

@merkys
Copy link

merkys commented Feb 20, 2024

Many thanks for switching to MIT license for InChI! I believe such change in licensing will benefit everyone.

While looking at what is on InChI GitHub repository, I noticed some licensing notation inconsistencies.

First of all, in the source released as v1.07-beta.3, a lot of source files still bear the old copyright notice:

* This library is free software; you can redistribute it and/or modify it
* under the terms of the IUPAC/InChI Trust InChI Licence No.1.0,
* or any later version.

In strict sense individual file copyright notices override the top-level copyright indication. Would it be possible to replace there notices with ones mentioning MIT, or removing them altogether?

Second, in the source released as v1.07-beta.3 there is a file INCHI-1-SRC/LICENCE.pdf with the old InChI license. The existence of such file creates some ambiguity over the true license of the source.

Third, other source releases such as v1.06 now bear the new license statement in LICENSE file. Assuming this does not mean that previous InChI releases are now relicensed, the existence of this file in the earlier releases may as well cause some confusion over the true license of the source.

@JanCBrammer
Copy link
Collaborator

@merkys, thanks for the issue! We need to clean this up.

  • consistently license source files with MIT (see Parametrize version and file header #2)
  • remove obsolete references to previous license (e.g., INCHI-1-SRC/LICENCE.pdf)
  • correctly and consistently license legacy releases (v1.03 through v1.06)

@merkys
Copy link
Author

merkys commented Feb 20, 2024

Great, thanks for prompt response!

@JanCBrammer
Copy link
Collaborator

Third, other source releases such as v1.06 now bear the new license statement in LICENSE file. Assuming this does not mean that previous InChI releases are now relicensed, the existence of this file in the earlier releases may as well cause some confusion over the true license of the source.

@gblanke02, we need to decide if we re-license versions <= v1.06 with MIT or keep the original license.

@gblanke02
Copy link
Contributor

gblanke02 commented Feb 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants