-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFDI4Chem Repo #47
base: main
Are you sure you want to change the base?
NFDI4Chem Repo #47
Conversation
Contribution via issue #42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not 100% certain what this review invites the user to do. My gut feeling is this recipe only helps those that have a skill set high enough that they don't actually need this recipe. It doesn't tell the user about why these repos could help them. It tells the user about various services but I think the point of the cookbook is to walk a user through why this recipe is important to their work and show the user how to use services it shows. To be honest it all comes across a bit sales pitchy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I don't think this image is high enough resolution.
|
||
# About NFDI4Chem | ||
|
||
[NFDI4Chem](https://www.nfdi4chem.de/) is the Chemistry Consortium in the National Research Data Infrastructure for Germany [NFDI](https://www.nfdi.de/?lang=en) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is repeated in the other NFDI4 document. Happy to have the advertisement in both but think its worth discussing.
|
||
# NFDI4Chem Federation of Repositories & Search Service | ||
|
||
[Figure 1](images/NFDI4Chem_Repo_fig1.png) displays the repositories chosen by NFDI4Chem as the foundation of its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment regarding this image above
Contribution via issue #42