Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFDI4Chem Repo #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NFDI4Chem Repo #47

wants to merge 2 commits into from

Conversation

stuchalk
Copy link
Member

Contribution via issue #42

Contribution via issue #42
@stuchalk stuchalk added the contribution A new proposed addition to the cookbook label Feb 28, 2024
@stuchalk stuchalk self-assigned this Feb 28, 2024
Copy link
Collaborator

@Smund27 Smund27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not 100% certain what this review invites the user to do. My gut feeling is this recipe only helps those that have a skill set high enough that they don't actually need this recipe. It doesn't tell the user about why these repos could help them. It tells the user about various services but I think the point of the cookbook is to walk a user through why this recipe is important to their work and show the user how to use services it shows. To be honest it all comes across a bit sales pitchy.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I don't think this image is high enough resolution.


# About NFDI4Chem

[NFDI4Chem](https://www.nfdi4chem.de/) is the Chemistry Consortium in the National Research Data Infrastructure for Germany [NFDI](https://www.nfdi.de/?lang=en)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is repeated in the other NFDI4 document. Happy to have the advertisement in both but think its worth discussing.


# NFDI4Chem Federation of Repositories & Search Service

[Figure 1](images/NFDI4Chem_Repo_fig1.png) displays the repositories chosen by NFDI4Chem as the foundation of its
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment regarding this image above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution A new proposed addition to the cookbook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants