[TG Mirror] Adds on_mob_life SHOULD_CALL_PARENT, fixes holy water metabolizing at double rate [MDB IGNORE]
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ffmirrorbot[bot]](https://avatars.githubusercontent.com/in/391347?s=60&v=4){kind=small}
…tabolizing at double rate [MDB IGNORE] (#24309) * Adds `on_mob_life` `SHOULD_CALL_PARENT`, fixes holy water metabolizing at double rate (#78932) ## About The Pull Request - Fixes #78919 - Adds `SHOULD_CALL_PARENT` to reagent `on_mob_life`, fixes a few places which didn't call parent - Off the top of my head I remembered holy water purposefully didn't call parent to get a static metabolism rate. However #78657 added a parent call to holy water, meaning it's been metabolizing out twice, incredibly fast. Fixes that. ## Why It's Good For The Game Reagent parent is fairly important as it handles removing the reagent from the mob. ## Changelog :cl: Melbert fix: Fixes Mauna Loa, Monover, Silibinin, Granibitaluri not exiting your system on metabolism fix: Fixes holy water exiting your system at double the rate on metabolism fix: Holy Water no longer spams cultists with big text every time, it's much more tame now /:cl: * Adds `on_mob_life` `SHOULD_CALL_PARENT`, fixes holy water metabolizing at double rate --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: ${this.url}
Original PR: (original url)
About The Pull Request
Fixes #78919
Adds
SHOULD_CALL_PARENTto reagenton_mob_life, fixes a few places which didn't call parentOff the top of my head I remembered holy water purposefully didn't call parent to get a static metabolism rate. However #78657 added a parent call to holy water, meaning it's been metabolizing out twice, incredibly fast. Fixes that.
Why It's Good For The Game
Reagent parent is fairly important as it handles removing the reagent from the mob.
Changelog
🆑 Melbert
fix: Fixes Mauna Loa, Monover, Silibinin, Granibitaluri not exiting your system on metabolism
fix: Fixes holy water exiting your system at double the rate on metabolism
fix: Holy Water no longer spams cultists with big text every time, it's much more tame now
/:cl: